tags 775472 pending thanks On Fri, Jan 16, 2015 at 03:50:58PM +1100, Ian Bissett wrote: > Package: debian-goodies > Version: 0.64 > > lsof takes a long time to return on systems with a large number of > files, causing checkrestart to take several minutes to run. lsof also > uses lots of CPU resources on systems with a large number of open > files. (....)
Thanks a lot for your patch. I have done some tests and it does seem to produce the exact same results as with using Lsof. I have included it in a modified version in the GIT repository. I have kept the code to run lsof, however, and it is still the default behaviour. I would like to do wider testing of the new code before making it the default. As this patch makes checkrestart independent of lsof I have done the required changes to use it if lsof is not available (IIRC some *BSD systems do not have it). With a little bit more testing I can think we can make this the default behaviour (and have 'lsof' as an option, to have the option for users to use it in case this fails). Regards Javier
signature.asc
Description: Digital signature
