Source: maxima
Severity: wishlist
Tags: patch

Dear maintainer,

the maxima package fails to build from a git repository, because the
upstream configure script replaces the version by the output of "git
describe --dirty", which causes files to be installed to the wrong path.
The attached patch fixes this.

When I rebuild a package, the first thing I do is to put it into a local
git repository to track what I'm doing, so it would be nice for the
package to build even if it's in git.

Best,
Tobias
Description: Allow package to be build from within a git repository
 The removed code screws up the version number if a git repository
 is present. This causes files to be installed to wrong paths and
 the package fails to build.
Author: Tobias Hansen <than...@debian.org>

--- a/configure.ac
+++ b/configure.ac
@@ -111,20 +111,12 @@
 
 dnl See if git exists.  If it does, update VERSION to include a git tag
 AC_CHECK_PROG(git_found, git, true, false)
-if test x"${git_found}" = xtrue; then
     # Test to see if git describe works (discarding any output).  If
     # it works, use it.  Otherwise, keep existing value of VERSION.
     # (git describe fails if git is executed in a non-Git directory, e.g.,
     # an unpacked tarball. Since the exit codes of git describe are undocumented,
     # we cannot distinguish that from a missing annotated tag.
     # Play it safe by refusing to change VERSION.)
-    if git describe > /dev/null 2>&1; then
-        VERSION="`git describe --dirty`"
-        # When building RPMs, hyphens in the version are not allowed, so
-        # replace them with underscores.
-        VERSION=`echo $VERSION | sed 's;-;_;g'`
-    fi
-fi
 
 dnl Parses the version number for the manual
 manual_version=`echo $VERSION | sed 's+branch_++; s+_base++; s+_dirty++; s+_+.+g'`

Reply via email to