Hi Paul, >All good points Harlan. I also won't be sponsoring this.
thanks to you too! (now we have the ack) >That tool doesn't appear to be run at build time to generate the>manual page, >which means that if downstream folks patch the command >they won't get an updated manual page. I'd strongly suggest that the >manual page be removed from the upstream git repos and tarballs and >that the manual page be created at package build time. The script used >to create the manual page would have to be added to the tarballs, >currently it is only available in git. I opened upstream issue 505 https://github.com/s3tools/s3cmd/issues/505 > That will require changing the watch file from github to sourceforge. >An alternative would be to ask upstream to upload all of their >tarballs and detached OpenPGP signatures to GitHub in addition to >SourceForge. I'd recommend that they do that anyway so people who >prefer GitHub can get them from there. I see them here https://github.com/s3tools/s3cmd/releases is that enough? uscan seems to be missing some bits, because it doesn't pick up the key >python-magic is dropped from the recommends and isn't in depends, was >that intended? I'd suggest using debdiff or debbindiff to compare >binary packages before future uploads. yes, seems picked up by install_requires install_requires = ["python-dateutil", "python-magic"] I checked the debian file and seems correct Depends: python-dateutil, python:any (>= 2.7.5-5~), python:any (<< 2.8), python, python-magic >debian/docs has an unnecessary blank line. fixed >Usually there are blank lines between the different contributors in >debian/changelog, did you use dch to prepare the changelog? yes, but sometimes I use vim too :) fixed >The homepage change isn't mentioned in debian/changelog. fixed >I'd suggest replacing /tmp/ with ~/ in the README.md examples and the >manual page. fixed and opened a pull request upstream >As this tool is for interacting with a remote network service, I'd >recommend implementing some post-install tests using the mechanisms >described in DEP-8. >http://dep.debian.net/deps/dep8/ mmm I don't have an amazon service "free" to test... seems difficult to achieve (we use a private key) >It would be good to get one or two screenshots illustrating how to use >this tool. >https://screenshots.debian.net/upload it is a command line tool, are them really necessary? >A build-time warning: >I: dh_python2 pydist:184: Cannot find package that provides >python_magic. Please add package that provides it to Build-Depends or >add "python_magic python-magic-fixme" line to debian/pydist-overrides >or add proper dependency to Depends by hand and ignore this info. I spotted it, but I don't know how to fix it, the python-magic seems correctly added by pydist. >lintian: I restored the patches, they disappeared. $ pep8 --ignore W191 . <lots of warnings> $ pyflakes . <lots of warnings> can I just report them upstream? https://github.com/s3tools/s3cmd/issues/506 I can fix them, but rewriting downstream is really bad in my opinion, I would like to help upstream fixing them and then wait for the next release. I opened upstream pull requests/issues 504-505-506-507 with all the fixes. (I'm currently uploading again on mentors) thanks Gianfranco -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org