Package: units
Version: 2.11-1
Followup-For: Bug #767864

Hello,

Thanks for maintaining units!  Love it.

I have two suggestions,

  1) Simply a refinement of Mike's proposal: Depend on or suggest
     python-unidecode instead of python:all, it's compatible with Python
     2 and 3, so this does the trick just as well.

  2) Change units_cur a bit to avoid warnings from unidecode when trying
     to decode simple ASCII strings.  With that, I can run units_cur
     every week or so as a cronjob without reading unidecode's
     RuntimeWarning over and over again.  Here's the patch (unified
     diff):

--- /usr/bin/units_cur  2014-04-09 07:35:56.000000000 +0200
+++ units_cur   2015-03-24 11:56:15.584269473 +0100
@@ -50,8 +50,8 @@
 for i in xrange(len(names)):
   if names[i] == 'anguilla(ecd)':
     names[i] = 'eastcaribbeandollar'
-  ascii = unidecode(names[i])
-  if names[i] != ascii:
+  if type(names[i]) != str:
+    ascii = unidecode(names[i])
     if not foundunicode:
       foundunicode = True
       outstr += '# Unicode Currency Names\n\n!utf8\n'

-Hagen


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to