Control: tag 785736 + patch
On Tue 2015-05-19 13:59:36 -0400, Daniel Kahn Gillmor wrote:
>   https://reproducible.debian.net/rb-pkg/unstable/amd64/git-annex.html
>
> shows that the documentation shipped with git-annex appears to embed the
> timestamp of the build.  The embedded timestamp should probably be set
> based on the timestamp in the most recent changelog entry.

Sorry, i think most of these are actually *not* based on the time of the
build.  they're the timestamps of the comments, but they're produced
based on the current value of TZ (or the system timezone).

These should probably be fixed by setting TZ=UTC when building the docs,
something like this:

-----------
diff --git a/Makefile b/Makefile
index 14e55a4..31ce121 100644
--- a/Makefile
+++ b/Makefile
@@ -73,6 +73,7 @@ man:
        mkdir -p man
 
 docs: mans
+       TZ=UTC \
        $(IKIWIKI) doc html -v --wikiname git-annex --plugin=goodstuff \
                --no-usedirs --disable-plugin=openid --plugin=sidebar \
                --underlaydir=/dev/null --disable-plugin=shortcut \
-----------


> There are also a handful of other changes like:
>
> -<a 
> href="?do=goto&amp;​page=https%3A%2F%2Fww​w.​google.​com%2Faccounts%2Fo8%2​Fid%3Fid%3DAItOawmkBw​MWvNKZZCge_YqobCSILPM​eK6xbFw8">https:​/​/​www.​google.​com/​accounts/​o8/​id?id=AItOawmkBwMWvNK​ZZCge_YqobCSILPMeK6xb​Fw8</​a>
> +<a 
> href="?page=https%3A%​2F%2Fwww.​google.​com%2Faccounts%2Fo8%2​Fid%3Fid%3DAItOawmkBw​MWvNKZZCge_YqobCSILPM​eK6xbFw8&amp;​do=goto">https:​/​/​www.​google.​com/​accounts/​o8/​id?id=AItOawmkBwMWvNK​ZZCge_YqobCSILPMeK6xb​Fw8</​a>
>
> where the "do=goto" query parameter gets moved from one side to the
> other.  This looks like it might be from a non-deterministic hash of
> query params, which could be resolved by sorting the hash by key before
> serialization to the URL.


This part is blocked by (and will be fixed by)
https://bugs.debian.org/785738

        --dkg

Attachment: signature.asc
Description: PGP signature

Reply via email to