Control: tag -1 pending Hey Faidon,
Faidon Liambotis [2015-04-22 15:25 +0300]:
> -new_rule_pattern=$(echo "^SUBSYSTEM==\"net\", ACTION==\"add\"$match" | sed
> -re 's/([\?\*])/\\\1/g')
> +new_rule_pattern=$(echo "^SUBSYSTEM==\"net\", ACTION==\"add\"$match" | sed
> -re 's/([\?\*\{\}])/\\\1/g')
Thanks for spotting this! I tested this now with Marco's test script,
and it still works fine. Committed to master now:
http://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=3d02f64154
(to experimental too).
> I have to say... constructing regexps in shell is tricky and the
> whole escaping-with-sed logic feels like a hack. I think a literal
> grep (i.e. -F) would be better here, especially since I don't see
> the point of an exact match (even if the file was modified by the
> sysadmin, the right thing would to not write a new rule anyway).
> This is probably something to be considered post-jessie.
Yeah, the whole generator is a horrible thing.. For the future I
actually want to propose a bolder change:
https://lists.debian.org/debian-devel/2015/05/msg00170.html
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
