Package: src:openjdk-9
Version: 9~b64-1
Severity: important
User: [email protected]
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package left unowned files on
the system after purge, which is a violation of policy 6.8:

https://www.debian.org/doc/debian-policy/ch-maintainerscripts.html#s-removedetails

The leftover files are actually alternatives that were installed by the
package but have not been properly removed.

While there is ongoing discussion how to remove alternatives correctly
(see https://bugs.debian.org/71621 for details) the following strategy
should work for regular cases:
* 'postinst configure' always installs the alternative
* 'prerm remove' removes the alternative
* 'postrm remove' and 'postrm disappear' remove the alternative
In all other cases a maintainer script is invoked (e.g. upgrade,
deconfigure) the alternatives are not modified to preserve user
configuration.
Removing the alternative in 'prerm remove' avoids having a dangling link
once the actual file gets removed, but 'prerm remove' is not called in
all cases (e.g. unpacked but not configured packages or disappearing
packages) so the postrm must remove the alternative again
(update-alternatives gracefully handles removal of non-existing
alternatives).

Note that the arguments for adding and removing alternatives differ, for
removal it's 'update-alternatives --remove <name> <path>'.

Filing this as important as having a piuparts clean archive is a release
goal since lenny.

Several packages built from src:openjdk-9 leave alternatives around,
e.g. openjdk-9-jre-headless:

>From the attached log (scroll to the bottom...):

1m23.2s INFO: Warning: Package purging left files on system:
  /etc/alternatives/java-rmi.cgi -> 
/usr/lib/jvm/java-9-openjdk-amd64/bin/java-rmi.cgi   not owned
  /etc/alternatives/jjs -> /usr/lib/jvm/java-9-openjdk-amd64/bin/jjs     not 
owned
  /etc/alternatives/jjs.1.gz -> 
/usr/lib/jvm/java-9-openjdk-amd64/man/man1/jjs.1.gz      not owned
  /etc/alternatives/jstatd -> /usr/lib/jvm/java-9-openjdk-amd64/bin/jstatd      
 not owned
  /etc/alternatives/jstatd.1.gz -> 
/usr/lib/jvm/java-9-openjdk-amd64/man/man1/jstatd.1.gz        not owned
  /usr/bin/java-rmi.cgi -> /etc/alternatives/java-rmi.cgi        not owned
  /usr/bin/jjs -> /etc/alternatives/jjs  not owned
  /usr/bin/jstatd -> /etc/alternatives/jstatd    not owned
  /usr/lib/jvm/java-9-openjdk-amd64/     owned by: openjdk-9-jre-headless:amd64
  /usr/lib/jvm/java-9-openjdk-amd64/lib/         owned by: 
openjdk-9-jre-headless:amd64
  /usr/lib/jvm/java-9-openjdk-amd64/lib/amd64/   owned by: 
openjdk-9-jre-headless:amd64
  /usr/lib/jvm/java-9-openjdk-amd64/lib/amd64/server/    owned by: 
openjdk-9-jre-headless:amd64
  /usr/lib/jvm/java-9-openjdk-amd64/lib/amd64/server/classes.jsa         not 
owned
  /usr/share/man/man1/jjs.1.gz -> /etc/alternatives/jjs.1.gz     not owned
  /usr/share/man/man1/jstatd.1.gz -> /etc/alternatives/jstatd.1.gz       not 
owned

/usr/lib/jvm/java-9-openjdk-amd64/lib/amd64/server/classes.jsa
is not an alternative, but left anyway.

openjdk-9-jre has many more alternatives and also a directory left in /etc:
  /etc/java-6-sun/
that should be shipped by the package (or not being created at all)


cheers,

Andreas

Attachment: openjdk-9-jre-headless_9~b64-1.log.gz
Description: application/gzip

Reply via email to