Hallo,
* Guido Günther [Tue, Jul 07 2015, 07:12:16AM]:
> On Tue, Jul 07, 2015 at 01:17:36AM +0200, Eduard Bloch wrote:

> > I tried this and that and couldn't see the reason. The message is IMHO
> > kinda pointless; why does it not simply commit as it's told by the
> > command line? As the final guess I added
> > --git-upstream-tag='v%(version)s' to the command line and it suddenly
> > worked. So it looks like the option is not read from gbp.conf. How
> > should I know that? gbp.conf(5) does not tell me which ones are valid
> > there and which are not.
> > 
> > Out of blue, I added git-pristine-tar and git-pristine-tar-commit there
> > and got:
> > gbp:error: File contains parsing errors: 
> > /home/user/debian/dev/encfs/debian/gbp.conf
> >     [line  5]: 'git-pristine-tar\n'
> >     [line  6]: 'git-pristine-tar-commit\n'
> > 
> > PARSING ERRORS?
> >
> > 
> > Or maybe something is not applicable in the DEFAULT section? Even if
> > that assumption is correct, the message should be something meaningful
> > and not a bogus "parsing error".
> 
> The docs say:
> 
>     All options in the config files are specified without the 'git-'
>     prefix.

Okay. What about helping the user a little bit? This seems to be a good
practice nowadays (have a look at git, for example). Haven't looked at
your code yet but it should be a three-liner in Python, something like:

if (foo not in dictionary AND foo.startsWith("git-") AND foo.substr(4) is in 
dictionary)
print "Unable to parse " + foo + ", did you mean " + foo.substr(4)
fi

> under "Configuation Files" of the man page. There are also examples
> around that document the format. Use these and all the above will again
> turn into non issues.

Sorry, not all of them.

$ gbp buildpackage 
gbp:error: File contains parsing errors: 
/home/user/debian/dev/encfs/debian/gbp.conf
        [line  5]: 'pristine-tar\n'
        [line  6]: 'pristine-tar-commit\n'

> I recommend to read an respect the references at
> 
>      /usr/share/doc/reportbug/HowToReportGoodBugs.txt
> 
> so I can figure out what exactly you have issues with.
> at 

Sure. I just had trouble pushing it. Feel free to have a look:
http://anonscm.debian.org/cgit/collab-maint/encfs.git/log/?h=debian/sid
And the repro step should be simply running "gbp buildpackage".

Regards,
Eduard.

-- 
<wenz> quit
<wenz> ~/quit
-!- wenz [~ho...@pd900e60c.dip.t-dialin.net] has quit [ircII2.8.2-EPIC3.004 ---
        Bloatware at its finest.]


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to