On Mon, Jul 13, 2015 at 11:54:52PM +0200, Torsten Landschoff wrote: > On 06/27/2015 05:59 AM, Mattia Rizzolo wrote: > > Hi subversion, unbound and swig maintainers, > > we in the Reproducible Builds effort use a non default dpkg which export > > -Wdate-time through dpkg-buildflags. > thanks for that great effort. I think this is urgently needed and I > often wonder if it is a good idea to install a given binary. > Most of the time I do not think much about using apt-get install > something and more about installers from github that are not packaged, > but this project really gives me a reason to trust Debian more. Thanks! :-)
Alway happy to hear people being happy for our effort :) > > There are package that pass CPPFLAGS (for example) quite unchanged to swig. > I already noticed that before and was wondering if it is a good idea. > SWIG should mostly care for defines for the preprocessor and include > paths, but of course the easy way is to just pass everything on. > > Sadly swig does not recognize -Wdate-time and choke and fail on it badly, > > e.g. > > > > /usr/bin/swig -I. -Wdate-time -D_FORTIFY_SOURCE=2 -I/usr/include/python2.7 > > -I/usr/include/python2.7 -o pythonmod/interface.h -python > > ./pythonmod/interface.i > > swig error : Unrecognized option -Wdate-time > > Use 'swig -help' for available options. > > Makefile:369: recipe for target 'pythonmod/interface.h' failed > > make[1]: *** [pythonmod/interface.h] Error 1 > A link to the documentation would have been helpful: > https://gcc.gnu.org/gcc-4.9/changes.html#languages (changelog, seems not > to be in the docs yet). > > warns when the |__DATE__|, |__TIME__|or |__TIMESTAMP__|macros are used. > > Seriously, I did not even know about this macros. Wouldn't it make more > sense to just fill those from a common constant? I bet this will often > be used for library build information. You mean substitute __DATE__, __TIME__ and __TIMESTAMP__ with a fixed date. We already thought that :) https://gcc.gnu.org/ml/gcc-patches/2015-06/msg02210.html But that would be a quite radical change of behaviour and we wouldn't like that to be a debian-only thing. OTOH we had a plans to get dpkg add -Wdate-time to the default set of flags expoerted by dpkg-buildflags, so at least maintainer (the ones who read the build logs, at least...) would get bothered by this. > > a. swig stops failing so badly on unrecognized options. If you really want > > to > > validate the options at least stop failing on unrecognized -W? Seems > > quite > > logical to pass CPPFLAGS to swig to me, and as such sounds sane > IMO just skipping over all -W options in the swig command line parser > would be sane. I will take this upstream though as I'd rather not have > this as special Debian feature as it might make matters better for > Debian and worse for other distributions in case upstream relies on this > feature. > I will reword this slightly (linking to this original text) and take it > upstream. Thanks for this. Please do keep me updated. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: Digital signature
