Joachim Wiedorn schrob: > now I have made a new package and tried to fix the bug > which you have reported. This package is already in > unstable, but in 5 days also in testing (I hope so). > Please test this new package and send me a feedback.
I did both an incremental and a full backup and a restore/diff for each,
both coming back clean, so the new package works.
My setup doesn't use the exclude file, so I also added a plain filename
and an incomple* to the exclude file and verified the files got
dropped from a subsequent backup run.
Upon re-reading the duplicity changelog, it seems that they are indeed
saying "--{in,ex}clude-globbing-filelist has been renamed to
--{in,ex}clude-filelist, and their previous functionality removed."
If that's true, then your patch appears correct to me as well, with the
minor issue of using
[ cond1 -a cond2 ]
instead of
[ cond1 ] && [ cond2 ]
The rest of duply uses the latter style, and the former is at least not
in posix¹, so you might want to change that before submitting the patch
upstream.
Apart from that, everything looks good to me.
Thank you for so quickly taking care of the issue.
regards,
Jan
¹ "man bash" also only documents "-a file" and doesn't mention any boolean
AND operator, but it certainly works.
signature.asc
Description: Digital signature
