Hi Did you mean to close the bug?
About the dep5 copyright issue, yes, I accidentally left out the header. I will fix the use-flag patch as you described. About the man page, the reason I didn't have it be installed by dh_manpages is the man page is edited in the Makefile, adding the version number (see make target 'man'). Should I add the version number myself and have it be installed by dh? Regards, Thomas On Friday, 21 August 2015, Gianfranco Costamagna <locutusofb...@debian.org> wrote: > Control: owner -1 ! > > Control: tags -1 moreinfo > > Hi Thomas, > > the version in mentors has no dep5 copyright. > > Bonus point for having a dh rules file (seems trivial) > > another problem regarding the use-flag patch. > > - $(CC) $(OBJFILES) -g -o rolldice $(LIBS) > + $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $(OBJFILES) -g -o rolldice > $(LIBS) > > > I would move LDFLAGS at the end, near LIBS, because otherwise they might > be stripped by the linker > (not sure, but I guess the linker might strip libraries if the previous > object files in the command line are not using them) > > BTW do you install the manpage? I guess you might want to install by > dh_manpages, the same for installdocs... > > I guess a dh default call might do everything the rules file does right now > > after that I guess it is good (note I still need to check the copyright > and to build it) > > BTW > > License: GPL-2+ > > License: GPL-2 > > > you need to describe the same license as above, not a different one :) > > (it might be fixed in the dep5 copyright that hasn't been uploaded, don't > know) > > cheers, > > G. >
