tag 782676 patch thanks On Thu, Apr 16, 2015 at 10:30:18AM +1000, Kevin Ryde wrote: > Package: libgraph-perl > Version: 1:0.96-1.1 > Severity: minor > File: /usr/share/perl5/Graph.pm > > Running > > perl -w -MGraph /dev/null > > gives a warning > > Argument "2.49_01" isn't numeric in numeric ge (>=) at (eval 6) line 1. > > which I believe is due to the version check at the start of Graph.pm. > > It'd be good if that check was done with ->VERSION() so version.pm can > crunch the dodgy cpanish "2.49_01" in Storable.pm of perl 5.20.xyz.
This warning also affects other packages: using libgraph-d3-perl currently triggers it too, see #785031. For your convenience, I'm attaching a patch with Kevin's suggested fix. I've tested that it fixes the issue while keeping the test suite passing. Please let me know if you'd like an NMU. The pkg-perl group is also happy to adopt the package in case you don't want to maintain it anymore. Thanks for your work on Debian, -- Niko Tyni nt...@debian.org
>From f3268a0295ec4433c3154adb2572b4712570886e Mon Sep 17 00:00:00 2001 From: Niko Tyni <nt...@debian.org> Date: Sat, 19 Sep 2015 20:41:47 +0300 Subject: [PATCH] Don't compare version numbers numerically Perl 5.20.2 has Storable 2.49_01, which generates warnings when compared as a number. Use UNIVERSAL::VERSION() instead, as suggested by Kevin Ryde. Bug-Debian: https://bugs.debian.org/782676 --- lib/Graph.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/Graph.pm b/lib/Graph.pm index e96acb4..cb9c06c 100644 --- a/lib/Graph.pm +++ b/lib/Graph.pm @@ -19,7 +19,13 @@ $VERSION = '0.96'; require 5.006; # Weak references are absolutely required. my $can_deep_copy_Storable = - eval 'require Storable; require B::Deparse; $Storable::VERSION >= 2.05 && $B::Deparse::VERSION >= 0.61' && !$@; + eval { + require Storable; + require B::Deparse; + Storable->VERSION(2.05); + B::Deparse->VERSION(0.61); + } + && !$@; sub _can_deep_copy_Storable () { return $can_deep_copy_Storable; -- 2.5.1
