On Sun, Sep 27, 2015 at 10:38:27AM +0200, Gianfranco Costamagna wrote: > Hi, > > sorry for the long wait!
Hi, no problem! > I did a deep review, and I guess I found the last "showstoppers" > > 1) Upstream revision seems to be "2.1-3" and you seem to have > introduced a first dfsg revision > so it becomes 2.1-3+dfsg > > and then the debian revision, so 2.1-3+dfsg-1 > > what do you think about? this should make easier for people to > understand where upstream stops and where Debian starts > > BTW if you have to strip other non-dfsg files you might just change > dfsg to dfsg1 and live happy, and if you need a new Debian upload, you > can change -1 to -2, that way people will understand the revision > correctly. > (note: this might imply a change in debian/NEWS too) No problem, replaced version in d/changelog and d/NEWS to "2.1-3+dfsg-1". > 2) control: the pre-depends might be dropped after jessie I guess, but > you can leave them because they are mentioned on the wiki (somebody > wrote about updating the wiki, but I won't ask to remove them for now, > because they might be useful for backports and lintian doesn't complain) Will keep in mind, thanks! > 3) I would appreciate a get-orig-source target called by uscan, that > way you can have a repack for free, otherwise another person looking > at the source might introduce non dfsg files in the packaging. > > you can look at files-excluded > https://wiki.debian.org/UscanEnhancements > > or write your own get-orig-source.sh script > e.g. (boinc) > version=3 > opts=dversionmangle=s/\+dfsg$// \ > https://github.com/BOINC/boinc/tags > .*/client_release/\d\.\d/(\d.*)\.tar\.gz \ > debian /bin/sh debian/get-orig-source.sh Done using d/copyright, thanks. > 4) manpages should belong to dh_installman instead of dh_install. > e.g. > debian/package.manpages > (or dh_installman(1)) Fixed. > 5) > export DEB_CFLAGS_MAINT_APPEND = -Wall -g > export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs > > ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS))) > DEB_CFLAGS_MAINT_APPEND += -O0 > else > DEB_CFLAGS_MAINT_APPEND += -O2 > endif > > > are you sure this is needed? AFAIK with compat level 9 this is > addressed automatically, unless upstream overrides the flags. I gladly removed this. Thanks for your notes. I've uploaded to mentors with all commented issues addressed: $ dget -x http://mentors.debian.net/debian/pool/main/c/cunit/cunit_2.1-3-dfsg-1.dsc