Control: found -1 1.23-4

On Sat, Oct 17, 2015 at 11:51:07AM +0000, Debian Bug Tracking System wrote:

> Changes:
>  libchado-perl (1.23-4) unstable; urgency=medium
>  .
>    * Enable reproducible builds (Thanks for the patch to Niko Tyni
>      <nt...@debian.org>)
>      Closes: #802042

Thanks for uploading the patch so fast, but unfortunately it didn't fix
the issue after all.  Please accept my apologies for insufficient testing.

The generated build.conf is not installed as-is in the binary package:
rather, conf_install.pl later reads it in and generates another very
similar one based on that, again outputting the lines in a random order.

I'm reopening this and attaching a new patch. The previous one is not
needed at all as it doesn't matter which order build.conf gets read in.

This time I've actually tested locally that the patch should fix the issue.
Sorry again for the trouble,
-- 
Niko Tyni   nt...@debian.org
>From c0ddde5111e062b293bfad25edd1593870b2fc53 Mon Sep 17 00:00:00 2001
From: Niko Tyni <nt...@debian.org>
Date: Sat, 17 Oct 2015 11:44:57 +0300
Subject: [PATCH] Sort installed configuration file for reproducibility

This makes the file stable between builds.
---
 install_util/conf_install.PLS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/install_util/conf_install.PLS b/install_util/conf_install.PLS
index c87c8ad..8c767db 100644
--- a/install_util/conf_install.PLS
+++ b/install_util/conf_install.PLS
@@ -71,7 +71,7 @@ print GMODCONF "VERSION=$version\n";
 close GMODCONF;
 
 open DBCONF,  ">$dbconf" or die "unable to open $dbconf: $!";
-foreach my $key (keys %confitems) {
+foreach my $key (sort keys %confitems) {
     print DBCONF  "$key=$confitems{$key}\n";
 }
 print DBCONF  "SQLFILE=$gmod_root/src/chado/modules/complete.sql\n";
-- 
2.5.1

Reply via email to