Hi Andreas,

unfortunately this change breaks libav 4:0.8.17-0ubuntu0.12.04.1 

the version in ubuntu precise (and travis-ci)

https://travis-ci.org/hedgewars/hw/jobs/89182800

cheers,

G.





Il Mercoledì 4 Novembre 2015 10:49, Gianfranco Costamagna 
<[email protected]> ha scritto:
Hi Andreas,


>
>That's not correct: the alternatives have been present for a
>long time, so that the deprecated functions will be removed
>in the next version.


thanks, this is something I was wondering, even if I couldn't easily find
when they were introduced.

>While this will probably work, it's not entirely correct.
>You can use:
>* for AVPixelFormat, AV_PIX_FMT_*:
>#if LIBAVUTIL_VERSION_MAJOR > 51
>* for av_frame_alloc/av_frame_free:
>#if LIBAVUTIL_VERSION_MAJOR > 52
>* for av_stream_get_end_pts:

>#if LIBAVFORMAT_VERSION_MAJOR > 55


thanks, I committed this on the upstream pull request, giving you the commit 
authorship.

While I like the solution, I'm really worried about backporting hedgewars,
(and this is why I took 55 as separator), because that way I wasn't changing 
the "current" behaviour.

Now the next backports will take some new functionalities, while before they 
were using a deprecated code...

This sounds scary to me, but if upstream applies the patch I have one year 
until the next backport need
(I'm backporting hedgewars without the above fixes for this new release)

let me know if you can reassure me because the changes are "safe" or whatever :)

cheers,


G.

Reply via email to