On Tue, 2006-01-03 at 10:53 -0500, Justin Pryzby wrote: > But I think it would be more readable as: > Not this: > http://.. > But this: > http://...
I agree. Fixed. > could be written more simply as > > + if( $last_line =~ m/-[0-9]/ ){ Also fixed. > Also I don't know if I agree with the requirement that the second to > last line be m/^\.$/. Fair enough. The only reason I added that was to reduce false positives where there is no homepage, but there is a url on the last line. > I would rather see my original, more aggressive check: > > $description=~m/homepage/is && $description!~/^ Homepage: [^ ]*$/ Hmm, this misses stuff where people use webpage on the last line, or a phrase without web or page in it, which is one thing I wanted to specifically detect, since I noticed it a few times. > Packages for which this is a false-positive (such as slash, gnudip, > and bake) These can be eliminated by checking for a url in the description too. > Will be orders of magnitudes more rare than packages which > are missed by the existing patch which are not missed by check above > (such as liblingoteach4, qgo, tcsh, maxdb-sqlcli, tik, mozart, > tagcoll, sleuthkit, tdl, xlogmaster, libsqlod75, wmpuzzle, > python2.3-dictclient, ...). How about the attached combination check - does my check and also does yours, with the changes that it checks a couple of other words, and checks for a url in the description too. -- bye, pabs http://wiki.debian.org/PaulWise
lintian-1.23.14-check-homepage-in-description-field.patch.gz
Description: GNU Zip compressed data
signature.asc
Description: This is a digitally signed message part