Package: needrestart
Version: 2.3-2
Severity: wishlist
Tags: patch
There are two grammar errors in the prompts produced by needrestart:
> Please consider to relogin or restart the affected processes!
The first problem is that "consider" cannot be followed by "to $VERB".
It has to be either "consider $VERBing" or "consider a $NOUN".
The second problem is that there's no such verb as "to relogin".
Indeed, there's no such one-word verb as "to login" - it's separable,
"to log (somebody) in". "A login" is okay, and you can just about get
away with the noun "a relogin" when it's standing next to "a restart",
but there certainly isn't a gerund form "relogin-ing".
The only option we're left with is:
Please consider a relogin or restart of the affected processes!
In the process of correcting this message I've made it consistent;
really this string ought to be defined in one place and made
translatable, but that sort of major surgery is a bit more than I can
justify for a grammar nitpick.
Please consider to checkin these changes.
-- Package-specific info:
needrestart output:
checkrestart output:
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (990, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 4.3.0-trunk-686-pae (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages needrestart depends on:
ii dpkg 1.18.3
ii libfile-slurp-perl 9999.19-4
ii libmodule-find-perl 0.13-1
ii libmodule-scandeps-perl 1.20-1
ii libproc-processtable-perl 0.53-1
ii libsort-naturally-perl 1.03-1
ii libterm-readkey-perl 2.33-1
ii perl 5.20.2-6
needrestart recommends no packages.
Versions of packages needrestart suggests:
pn needrestart-session | libnotify-bin <none>
-- no debconf information
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
diff -ru needrestart-2.3.pristine/ex/notify.d/200-write needrestart-2.3/ex/notify.d/200-write
--- needrestart-2.3.pristine/ex/notify.d/200-write 2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/200-write 2015-11-24 13:10:31.678994711 +0000
@@ -23,7 +23,7 @@
{
echo
echo "Your session is running obsolete binaries or libraries as listed below."
- echo "Please consider to relogin or restart them!"
+ echo "Please consider a relogin or restart of the affected processes!"
echo
cat
echo
diff -ru needrestart-2.3.pristine/ex/notify.d/400-notify-send needrestart-2.3/ex/notify.d/400-notify-send
--- needrestart-2.3.pristine/ex/notify.d/400-notify-send 2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/400-notify-send 2015-11-24 13:39:49.549460507 +0000
@@ -35,7 +35,7 @@
echo "[$0] notify user $NR_USERNAME on $DISPLAY" 1>&2
MSGTITLE='Relogin or restarts required!'
- MSGBODY="Your session is running obsolete binaries or libraries as listed below.\n<i><b>Please consider to relogin or restart the affected programs!</b></i>\n\n$(cat)"
+ MSGBODY="Your session is running obsolete binaries or libraries as listed below.\n<i><b>Please consider a relogin or restart of the affected processes!</b></i>\n\n$(cat)"
su -p -s /bin/sh -c "$NSEND -u critical -i dialog-warning \"$MSGTITLE\" \"$MSGBODY\"" "$NR_USERNAME"
;;
diff -ru needrestart-2.3.pristine/ex/notify.d/600-mail needrestart-2.3/ex/notify.d/600-mail
--- needrestart-2.3.pristine/ex/notify.d/600-mail 2015-09-19 19:38:36.000000000 +0100
+++ needrestart-2.3/ex/notify.d/600-mail 2015-11-24 13:07:25.200700726 +0000
@@ -25,7 +25,7 @@
{
echo "Your session on host $(hostname -f) ($NR_SESSION) is running obsolete binaries or libraries as listed below."
echo
- echo "Please consider to relogin or restart the affected processes!"
+ echo "Please consider a relogin or restart of the affected processes!"
echo
cat
} | fold -s -w 72 | "$MAILX" -s "Relogin or restarts on host $(hostname) required!" "$NR_USERNAME"
