Control: owner -1 ! Am 05.12.2015 um 11:55 schrieb Alexandre Detiste: > Package: sponsorship-requests > Severity: wishlist > > Dear mentors, > > I am looking for a sponsor for my package "corsix-th":
Hi Alexandre, here is my initial review. I am working with the pkg-games Git repository of corsix-th and I suggest we continue to use it instead of the mentors.debian.net packages. debian/control: You build-depend on wx2.8-headers but this package is obsolete and will be removed soon. Please either use wx3.0-headers instead or remove the build-dependency because I don't see anything in the sources that may need it. Why do you depend on lua-filesystem and lua-lpeg explicitly? If those dependencies are really required, the ${shlibs:Depends} substvar should include them already. Otherwise the build system should be updated to require and incorporate those libraries. desktop file: I have already fixed a few things that bothered me. I believe it's a simulation game and StartupNotify should be set to false. I also added keywords and a comment in German. Please tell me if you can live with the changes or if there is a reason to stick with the old values. Please forward the new desktop file upstream. Please use Debian's system library of tinyxml. The embedded copy of tinyxml in AnimView/ is neither mentioned in upstream's LICENSE.txt file nor in debian/copyright. Please ask upstream to remove the embedded copy or to offer a build system option to use the system library instead. They should also mention the copyright holders and license in LICENSE.txt. You can take a look at my Bullet package how I used Debian's tinyxml library. There are several issues with debian/copyright: Some copyright holders and licenses are missing. BSD-3-clause CMake/CMakeFFmpegLibavMacros.cmake CMake/FindFFmpeg.cmake CMake/FindLibAV.cmake CMake/FindSDL2.cmake CMake/FindSDL2_mixer.cmake public-domain CMake/FindDirectX.cmake CMake/FindLua.cmake CMake/FindPkgMacros.cmake Several Expat copyright holder are missing in CorsixTH/Lua/languages CorsixTH/Src/jit_opt.h SpriteEncoder/* LevelEdit/* GPL-3+ SpriteEncoder/parser.cpp SpriteEncoder/tokens.h zlib: WindowsInstaller/ReplaceInFile.nsh Why don't you build the level editor? Wouldn't this be a useful addition to the game? Lintian error: source-contains-unsafe-symlink I think it is safe to override this error and since upstream already removed the debian directory from Git master it will be fixed with the next release of corsix-th. Another option might be to remove the directory for the current version and to append +ds to the upstream version. Forwarding the Lua patch upstream is a good idea. I would change usr/lib/games/corsix-th/CorsixTH to /usr/lib/corsix-th/CorsixTH. We still use /usr/games and /usr/share/games for historical reasons but I think it is OK to omit the games subdirectory here. debian/scripts/corsix-th Please use the exec command. It replaces the current process without forking a new process. That's it for now. Regards, Markus
signature.asc
Description: OpenPGP digital signature