On Tue, Dec 08, 2015 at 03:17:49PM -0700, dann frazier wrote: > diff -Nru s390-tools-1.32.0/debian/changelog > s390-tools-1.32.0/debian/changelog > --- s390-tools-1.32.0/debian/changelog 2015-10-25 17:12:02.000000000 > +0100 > +++ s390-tools-1.32.0/debian/changelog 2015-12-08 23:14:52.000000000 > +0100 > @@ -1,3 +1,9 @@ > +s390-tools (1.32.0-2) UNRELEASED; urgency=medium > + > + * Add dbginfo.sh. (Closes: #807442) > + > + -- dann frazier <da...@debian.org> Tue, 08 Dec 2015 22:33:52 +0100 > + > s390-tools (1.32.0-1) unstable; urgency=medium > > * New upstream release > diff -Nru s390-tools-1.32.0/debian/s390-tools.install > s390-tools-1.32.0/debian/s390-tools.install > --- s390-tools-1.32.0/debian/s390-tools.install 2014-07-26 > 23:59:18.000000000 +0200 > +++ s390-tools-1.32.0/debian/s390-tools.install 2015-12-08 > 23:08:30.000000000 +0100 > @@ -10,6 +10,10 @@ > /sbin/dasdview > /usr/share/man/man8/dasdview.8 > > +# dbginfo.sh > +/sbin/dbginfo.sh > +/usr/share/man/man1/dbginfo.sh.1 > + > # fdasd > /sbin/fdasd > /usr/share/man/man8/fdasd.8
Three comments: * dbginfo.sh should tell the user that the information in the tarball is sensitive. * The resulting tarball should be 0600 by default. (The script needs to run as root anyway, but placing the result world-readable in /tmp does not seem smart.) * Unless this is expected to be in /sbin, given that it's user invoked and not usually scripted, should this be in /usr/sbin instead? Kind regards and thanks Philipp Kern
signature.asc
Description: Digital signature