Hi Thomas, thanks for the full review :) >- The following are not build time dependencies (OK, the setup script >will issue a warning if some of them are not available, but that's just >for info): > > gir1.2-gtk-3.0, > gir1.2-notify-0.7, > gobject-introspection, > libgtk-3-bin,
removed > python-docopt,> python-gi, > python-yaml, > python3-docopt, > python3-gi, > python3-yaml, yaml and docopt are listed in install_requires (setup.py). For this reason I have to add them to build-dependencies to see them automatically added to runtime dependencies (python:Depends substitution) >- yaml/gi/docopt are runtime dependencies instead (yaml is technically > not required, but recommended) yaml if recommended shouldn't be in install_requires then? gi is missing from the keyword >>- gir1.2-gtk3.0 AND gir1.2-notify-0.7 are optional runtime dependencies >>(again, recommended) ok >- a notification daemon is recommended (e.g. xfce4-notifyd or similar) mmm there is nothing like a meta-package for this, right? I added notification-daemon to recommends https://packages.debian.org/unstable/notification-daemon >- python-notify is not a runtime dependency > removed >- I have added an optional dependency on python-keyutils in the 1.4 series currently in new queue (thanks I noticed during the import of the new version :) ) >- I don't know about python-gi-cairo, what's that? it should be the gi cairo binding, but it seems to be useless https://packages.debian.org/unstable/python-gi-cairo >- I don't know about xsltproc/docbook-xsl, they are at least not>directly >required by udiskie. So if they're needed, they should be >resolved indirectly, right? (not sure, for what they would be needed) https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=789453 they are used by a2x :) (manpage creation) >- I think that gettext is only required for the build step. python has >its own gettext implementation (or it brings it in as a dependency?)>that can >be used at runtime. (NOT SURE) it is part of libpython*-stdlib package, so I guess we can drop it (apt-get install python drags it, while apt-get install python-minimal doesn't) >- I recommend using python3 from now on, I'm considering to abandon >python2 in a future version altogether. ok even better >- I believe, I saw in some distribution that they would require the >gnome-hicolor icon theme to prevent the udiskie package from taking >ownership for the /usr/share/icons/hicolor folder, but I don't know how >that works in your package manager;) I don't think this is an issue in Debian >Note, that I uploaded a new version (1.4.4) with important bug fixes for >the legacy targets (udisks1 and/or python2). I have it on my git, but I'll upload as soon as the new keyutils is accepted in unstable and I fixed the above (and this bug fix reaches testing) BTW from your wiki page "Manual installation First grep the following required runtime dependencies:" I would say build-time dependencies. cheers (and a lot of thanks) Gianfranco > > > http://anonscm.debian.org/cgit/collab-maint/python-udiskie.git/tree/debian/control > > cheers! > > G. > > > (new version uploaded a few seconds ago on unstable) >
