Gianfranco,

  think I have had success with the watch file.  I found that if you store
the signature within a branch (in this case the debian branch) then you can
directly access the .asc file via the watch file.

Also I've removed the unneeded "license removal" patch.  This just leaves
the patch to Makefile.am to ensure the LICENSE file is not added to the
debian binary

The latest revision has been uploaded to mentors.

thanks

David

On 29 December 2015 at 00:36, foss.freedom <foss.free...@gmail.com> wrote:

> ok - scratch that Gianfranco,
>
> I deleted the rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz file
> and reran uscan --debug --force-download
>
> It came back with the same 404 error
>
> GitHub saves attached downloads to the releases/download/v0.15.0 folder
> not to the archive folder
>
>
> https://github.com/fossfreedom/alternative-toolbar/releases/download/v0.15.0/v0.15.0.tar.gz.asc
>
> As I mentioned - my regex knowledge is very limited so I dont really
> understand how to modify the watch file.  I've read that link you gave me
> and I'm non-the-wiser as to how to change the watch file to find the .asc
> is the releases/download/{version} folder
>
> David
>
> On 29 December 2015 at 00:23, foss.freedom <foss.free...@gmail.com> wrote:
>
>> Hi Gianfranco,
>>
>>   strange that my uscan didnt pick that up.
>>
>> I've renamed the .asc file on the tag to v0.15.0.tar.gz.asc
>>
>> With regards to the license issue.
>>
>> I have to include the LICENSE part of Makefile.am so that those people
>> who compile directly from source correctly has the LICENSE file added to
>> the /usr/lib/rhythmbox/plugins/alternative-toolbar folder
>>
>> So at the very minimum I need at least a patch to remove the LICENSE part
>> of Makefile.am for Debian.
>>
>> As I mentioned in one of my emails above I couldnt get that dh-helper
>> statement working in my rules file - I raised this on unix & linux
>> stackexchange and someone mentioned you can't have cdbs and dh-helper type
>> statements in the same rule file.  I can't say if this is true or not -
>> just that I couldnt get it to work.
>>
>>  -
>> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake
>>
>> thanks
>>
>> David
>>
>> On 28 December 2015 at 23:33, Gianfranco Costamagna <
>> costamagnagianfra...@yahoo.it> wrote:
>>
>>> Hi,
>>>
>>>
>>> uscan warning: In directory ., downloading
>>>
>>> https://github.com/fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz.asc
>>> failed: 404 Not Found
>>>
>>>
>>> seems that you have to rename it (or tweak the regex)
>>>
>>>
>>> BTW remove license . patch seems difficult to maintain, what about
>>> dropping the two patches and do something like that in your rules file?
>>>
>>> override_dh_auto_install:
>>>     dh_auto_install
>>>     find debian/tmp -name "LICENSE" -delete
>>>
>>> it shoud work (note: I didn't test it)
>>>
>>> cheers,
>>>
>>> G.
>>>
>>> Il Lunedì 28 Dicembre 2015 21:21, foss.freedom <foss.free...@gmail.com>
>>> ha scritto:
>>>
>>>
>>>
>>> Gianfranco,
>>>
>>>   I've uploaded an updated package with your suggested watch file.
>>>
>>> According to the uscan results I got the following - I presume this
>>> means success?
>>>
>>> uscan debug: matching pattern(s) (?:(?:https://github.com
>>> )?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
>>> -- Found the following matching hrefs:
>>>      /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
>>>      /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
>>>      /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
>>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>>  => Package is up to date
>>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>>  => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in
>>> package directory '..'
>>> -- Scan finished
>>>
>>> thanks
>>>
>>> David
>>>
>>>
>>> On 28 December 2015 at 19:21, Gianfranco Costamagna <
>>> costamagnagianfra...@yahoo.it> wrote:
>>>
>>> Hi
>>> >
>>> >
>>> >>I'm trying to get rid of the last pedantic linitian issue which is the
>>> signing of the release.
>>> >>
>>> >>  I think I've figured out how to sign  the .tar.gz on github
>>> >>
>>> >>gpg --default-key 7B0393D9 --armor --detach-sign
>>> alternative-toolbar-0.15.tar.gz
>>> >
>>> >
>>> >wonderful!
>>> >
>>> >>Then I attached the .asc file to the release.
>>> >>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
>>> >
>>> >
>>> >exactly
>>> >
>>> >>I created a .pgp file in the debian folder with:
>>> >>
>>> >>gpg --export "the public fingerprint for the debian key" >
>>> debian/upstream-signing-key.pgp
>>> >>
>>> >>
>>> >>However I really dont understand regex and thus I dont know how to
>>> change the watch file from this:
>>> >>
>>> >>version=3
>>> >>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
>>> \
>>> >>  https://github.com/fossfreedom/alternative-toolbar/tags
>>> .*/v?(\d\S*)\.tar\.gz
>>> >>
>>> >>to something like this
>>> >>
>>> >>version=3
>>> >>pgpsigurlmangle=s/(what do I do here?)/.asc/ \
>>> >>
>>> >>https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno
>>> what here)\.tar.gz
>>> >>
>>> >>Any thoughts?
>>> >
>>> >
>>> >
>>> >not sure, maybe something like this?
>>> >opts=pgpsigurlmangle=s/$/.asc/
>>> >
>>> >so
>>> >version=3
>>> >opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
>>> \
>>> > https://github.com/fossfreedom/alternative-toolbar/tags
>>> .*/v?(\d\S*)\.tar\.gz
>>> >
>>> >this link might help
>>> >https://wiki.debian.org/debian/watch
>>> >
>>> >you can test the fix with uscan --debug --force-download
>>> >
>>> >
>>> >note: I didn't test the above, because there is no upload on mentors
>>> with the gpg public key inside.
>>> >(you might need to rename the asc file in the github release, please
>>> rely to the output of uscan --debug,
>>> >to know the correct file naming)
>>> >
>>> >cheers,
>>> >
>>> >G.
>>> >
>>> >
>>> >
>>> >On 21 December 2015 at 14:33, foss.freedom <foss.free...@gmail.com>
>>> wrote:
>>> >Hi Gianfranco
>>> >>
>>> >>
>>> >> I've re-uploaded to mentors.debian.net
>>> >>
>>> >>
>>> >>This corrects the issues mentioned previously.  Note - I've resolved
>>> the LICENSE issue by two debian/patches
>>> >>
>>> >>
>>> >>Note - This still produces an informational lintian issue with the
>>> remove-license.diff patch.  This is very odd because this does have a PEP3
>>> header on the diff file
>>> >>
>>> >>
>>> >>* Package name   : rhythmbox-plugin-alternative-toolbar Version      :
>>> 0.15.0-1
>>> >>I've uploaded a newer version with a new autotools build
>>> mechanism+patches here:
>>> >>http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar
>>> Alternatively, one can download the package with dget using this command:
>>> >>dget -x
>>> http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc
>>> >>
>>> >>
>>> >>
>>> >>
>>> >>thanks
>>> >>
>>> >>
>>> >>David
>>> >>
>>> >>
>>> >>On 21 December 2015 at 11:05, foss.freedom <foss.free...@gmail.com>
>>> wrote:
>>> >>
>>> >>Many thanks Gianfranco,
>>> >>>
>>> >>>
>>> >>>  to answer your questions
>>> >>>
>>> >>>
>>> >>>1. python3 - yes I should include this as a dependency - you are
>>> correct rhythmbox does have a dependency - but belt-and-braces
>>> >>>2. When the topic of changing the interface for rhythmbox came up on
>>> a bugzilla report, the rhythmbox maintainer dismissed very quickly the
>>> approach of using a python3 plugin.  Thus I havent attempted to upstream
>>> this
>>> >>>
>>> >>>
>>> >>> - https://bugzilla.gnome.org/show_bug.cgi?id=735648
>>> >>>
>>> >>>
>>> >>>With regards to the lintian report:
>>> >>>
>>> >>>
>>> >>>1.  W: rhythmbox-plugin-alternative-toolbar source:
>>> build-depends-on-python-dev-with-no-arch-any
>>> >>>
>>> >>>
>>> >>>There is no reason for the package to have a  build-depends on
>>> python3-dev so I'll remove this.
>>> >>>
>>> >>>
>>> >>>2. P: rhythmbox-plugin-alternative-toolbar source:
>>> debian-watch-may-check-gpg-signature
>>> >>>
>>> >>>
>>> >>>No idea on this - dont think GitHub provides a means to gpg-signature
>>> the tar.gz tag file
>>> >>>
>>> >>>
>>> >>>3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog
>>> >>>
>>> >>>
>>> >>>Think this means I need to change my source and thus bump the
>>> version.  If you don't mind I would like to bump this into a future version
>>> of the plugin.
>>> >>>
>>> >>>
>>> >>>4. I: rhythmbox-plugin-alternative-toolbar:
>>> capitalization-error-in-description Gnome GNOME
>>> >>>
>>> >>>
>>> >>>Doh! - yes, quite correct - I'll change all references for Gnome to
>>> GNOME in the description
>>> >>>
>>> >>>
>>> >>>5. W: rhythmbox-plugin-alternative-toolbar: extra-license-file
>>> usr/lib/rhythmbox/plugins/alternative-toolbar/LICENSE
>>> >>>
>>> >>>
>>> >>>I'm not sure how to do this - I thought of using a debian/rules
>>> override_dh_auto_install but this doesnt seem to be working.  If you have
>>> any thoughts on this I would be very grateful - for the moment I've created
>>> a unix-and-linux stackexchange question and I hope someone can answer:
>>> >>>
>>> >>>
>>> >>> -
>>> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake#250683
>>> >>>
>>> >>>
>>> >>>thanks
>>> >>>
>>> >>>
>>> >>>David
>>> >>>
>>> >>>
>>> >>> -
>>> >>>
>>> >>>
>>> >>>On 21 December 2015 at 09:20, Gianfranco Costamagna <
>>> costamagnagianfra...@yahoo.it> wrote:
>>> >>>
>>> >>>Hi,
>>> >>>>
>>> >>>>
>>> >>>>
>>> >>>>the package looks really nice now!
>>> >>>>
>>> >>>>however there still are some minor issues here
>>> >>>>
>>> http://debomatic-amd64.debian.net/distribution#unstable/rhythmbox-plugin-alternative-toolbar/0.15.0-1/lintian
>>> >>>>
>>> >>>>can you please address them? the package works in both debian and
>>> ubuntu.
>>> >>>>
>>> >>>>I have a few questions:
>>> >>>>1) isn't python3 a runtime dependency? (not a problem, because seems
>>> that rhythmbox already depends on it)
>>> >>>>2) why didn't you upstream the plugin into the rhythmbox-plugins
>>> package?
>>> >>>>https://packages.qa.debian.org/r/rhythmbox.html
>>> >>>>
>>> >>>>thanks,
>>> >>>>
>>> >>>>Gianfranco
>>> >>>>
>>> >>>
>>> >>
>>> >
>>>
>>
>>
>

Reply via email to