Package: unicode-screensaver
Version: 0.4-2
Severity: normal
Tags: upstream patch

Dear Maintainer,

unicode-screensaver sometimes shows "U+ABCD: something is wrong" in the
footer, in place of "U+ABCD: <Name of character>".

This make it hard to distinguish the error message from actual content
(character names).  Would it be possible to increase the differentiation
between error messages and from character names?

I propose this:

diff --git a/unicode.c b/unicode.c
index 3c19244..b424351 100644
--- a/unicode.c
+++ b/unicode.c
@@ -107,5 +107,5 @@ get_unicode_data_name (FcChar32 uc)
                        return unicode_name_get_name(&unicode_names[mid]);
        }
 
-       return "something is wrong";
+       return "�";
 }


(To be clear, that's a literal U+FFFD in the patch.)

Thank you for making unicode-screensaver! ☺

Daniel

P.S. I didn't try to build with this patch, but I applied it directly to
the packaged binary and it worked as expected.

-- System Information:
Debian Release: 8.1
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'testing-updates'), (500, 
'stable-updates'), (250, 'testing'), (200, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages unicode-screensaver depends on:
ii  libc6           2.19-18+deb8u1
ii  libfontconfig1  2.11.0-6.3
ii  libfreetype6    2.5.2-3+deb8u1
ii  libx11-6        2:1.6.2-3
ii  libxft2         2.3.2-1
ii  libxmu6         2:1.1.2-1
ii  libxt6          1:1.1.4-1+b1

Versions of packages unicode-screensaver recommends:
ii  xscreensaver  5.30-1+b1

unicode-screensaver suggests no packages.

-- no debconf information

Reply via email to