Package: libdpkg-perl
Version: 1.18.4
Severity: normal

Dear Maintainer,

The quilt package format's check_patches_applied() silently fails to 
apply patches if the first patch in the series emits a warning. An 
example is the current version of python-letsencrypt (0.1.1-3), whose 
first patch in the series patches a file twice - thus emitting a 
warning:

 tmp/letsencrypt-0.1.1 $ dpkg-source --before-build .
 dpkg-source: warning: diff 
'letsencrypt-0.1.1/debian/patches/permission-failures.patch' patches file 
letsencrypt-0.1.1/letsencrypt/plugins/webroot_test.py twice
 dpkg-source: warning: diff 
'letsencrypt-0.1.1/debian/patches/permission-failures.patch' patches file 
letsencrypt-0.1.1/letsencrypt/plugins/webroot_test.py twice
 /tmp/letsencrypt-0.1.1 $ 

Re-ordering the patches in the series file leads to the whole series 
being applied normally. Since patching the same file twice is a warning 
and not an error, it should not stop dpkg-source --before-build from 
applying the series.

Regards,
Apollon

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable'), (90, 'unstable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, mips

Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=el_GR.UTF-8, LC_CTYPE=el_GR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libdpkg-perl depends on:
ii  dpkg  1.18.4
ii  perl  5.20.2-6

Versions of packages libdpkg-perl recommends:
ii  bzip2                   1.0.6-8
ii  libfile-fcntllock-perl  0.22-3
ii  xz-utils                5.1.1alpha+20120614-2.1

Versions of packages libdpkg-perl suggests:
ii  binutils              2.25.90.20151209-1
ii  debian-keyring        2015.11.30
ii  gcc [c-compiler]      4:5.3.1-1
ii  gcc-4.6 [c-compiler]  4.6.4-7
ii  gcc-4.7 [c-compiler]  4.7.4-3
ii  gcc-4.8 [c-compiler]  4.8.5-3
ii  gcc-4.9 [c-compiler]  4.9.3-10
ii  gcc-5 [c-compiler]    5.3.1-4
ii  gnupg                 1.4.20-1
ii  gnupg2                2.0.28-3
ii  gpgv                  1.4.20-1
ii  patch                 2.7.5-1

-- debconf-show failed

Reply via email to