Hi ! > please use autoreconf instead of autotools-dev > (dh-autoreconf and call dh --with autoreconf) done
> please remove all the comments from rules file > and also the two lines below > DPKG_EXPORT_BUILDFLAGS = 1 > include /usr/share/dpkg/default.mk done > " > * This is my first Debian package > > " > > this isn't so much useful in the user experience, please remove :) done > remove debian/rules.dh7 done > please enable VCS fields done I re-uploaded an updated version of the package. > check-all-the-things review: > flawfinder -Q -c . > > > (lots of security issues) Thanks, I didn't know about this tool. It's no surprise that there's a lot of security issues, PNMixer code is not exactly the best C code you've ever seen. But it's going better, and I'll make good use of `flawfinder`. Though this will happen on the development branch, not on the current 0.6. > pnmixer is designed to work on systems that use ALSA for sound management. > Any other sound driver like IOSS or FFADO, or sound server like PulseAudio > or Jackd, are currently not supported (patches welcome). > > > seems kind of a blocker, many users are left out... Hmm, well at the moment PNMixer is made for a specific use-case: people who use ALSA. There are several reasons to use Alsa rather than PulseAudio, though I have no idea really how much people do that. We're open to patches, so if someone jump in saying "I want PNMixer for OSS, here comes a patch", we will surely work with that guy to make it happen. But for the moment, it's only ALSA, and since we (developers) don't use anything else, it will remain like that until someone needs PNMixer another way. So yes, many users are left out. We solve a specific use-case and try to do it good. We don't try to be the ultimate system tray mixer :) Anyway, thanks a lot for your review. There's also two lintian warnings that you may have missed ;) It's also something that I'll solve in the dev branch. Cheers Arnaud On 01/12/2016 05:04 AM, Gianfranco Costamagna wrote: > control: owner -1 ! > control: tags -1 moreinfo > > > little review: > please use autoreconf instead of autotools-dev > (dh-autoreconf and call dh --with autoreconf) > > please remove all the comments from rules file > and also the two lines below > DPKG_EXPORT_BUILDFLAGS = 1 > include /usr/share/dpkg/default.mk > > > " > * This is my first Debian package > > " > > this isn't so much useful in the user experience, please remove :) > > remove debian/rules.dh7 > > please enable VCS fields > > > pnmixer is designed to work on systems that use ALSA for sound management. > Any other sound driver like IOSS or FFADO, or sound server like PulseAudio > or Jackd, are currently not supported (patches welcome). > > > seems kind of a blocker, many users are left out... > > > check-all-the-things review: > flawfinder -Q -c . > > > (lots of security issues) > > cheers, > > Gianfranco > > > > > > Il Mercoledì 9 Dicembre 2015 5:48, Arnaud Rébillout <elboulang...@gmail.com> > ha scritto: > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "pnmixer". > > Package name : pnmixer > Version : 0.6.1-1 > Upstream Author : Nick Lanham, Julian Ospald, Arnaud Rébillout > URL : https://github.com/nicklan/pnmixer > License : GPL-3 > Section : sound > > This is my first package. > > I built it carefully using `dh_make`, checked and fixed errors with > `lintian`. It took me almost two days, given the huge amount of > documentation out there :) > > PNMixer is a simple mixer application for the system tray, for those > who use ALSA for sound management. It may be people who like to keep > their system simple and lightweight, or people who do MAO, therefore > using Jackd when working on their music, and simple ALSA when they're > not. I'm part of both use cases. > > PNMixer integrates nicely into desktop environments that don't have > a panel that supports applets and therefore can't run a mixer applet. > In particular it's been used quite a lot with fbpanel and tint2, but > should run fine in any system tray. > > PNMixer comes with plenty of options, which make it quite a complete > system tray mixer: hotkeys support, notifications, plenty of config... > This is described in details in the README. > > How does it compare with other system tray ALSA mixers in Debian ? > - qasmixer is C++/Qt4, no translation > - volumeicon-alsa is C/GTk2, no translation > - volti is Python/GTk2, translated in 5 languages > > PNMixer is C/GTk3, translated in 4 languages. > > It has been around for almost 5 years now, and is actively maintained. > It is packaged in several distributions: > > - ArchLinux: https://aur.archlinux.org/packages/pnmixer/ > - Gentoo: https://packages.gentoo.org/packages/media-sound/pnmixer > - Fedora: https://apps.fedoraproject.org/packages/pnmixer > > It was also the default sound mixer in Crunchbang, a Debian-derived > distribution that is known as BunsenLabs now. There's also an unofficial > package for Ubuntu. > > I'm one of the maintainers of PNMixer, so yes, I'm advertising a little > bit here :) > > However, before being a maintainer, I was a PNMixer user, because it was > definitely the best system tray ALSA mixer around. I sincerely believe > that it's a valuable piece of software, and that Debian users can > benefit from it. > > To access further information about this package, please visit the > following URL: > > http://mentors.debian.net/package/pnmixer > > Alternatively, one can download the package with dget using this > command: > > dget -x > http://mentors.debian.net/debian/pool/main/p/pnmixer/pnmixer_0.6.1-1.dsc > > Best regards, > > Arnaud Rébillout > > > > -- System Information: > Debian Release: stretch/sid > APT prefers unstable > APT policy: (500, 'unstable'), (1, 'experimental') > Architecture: amd64 (x86_64) > Foreign Architectures: i386 > > Kernel: Linux 4.2.0-1-amd64 (SMP w/8 CPU cores) > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: systemd (via /run/systemd/system)
