Control: tag -1 - patch + moreinfo
Hi Pino,
Pino Toscano wrote:
> the provided links2.desktop is not completely valid (see also output
> of `desktop-file-validate`).
Thanks for the hint to that tool. Didn't know it.
> The attached git-formatted commit fixes all the issues:
> - the 'Keywords' key is a list, so it must end with the list separator
> (';')
Thanks. Wasn't aware of that issue.
> In addition, a couple of helpful keywords are added to that.
[...]
> Categories=Network;WebBrowser;
[...]
> +Keywords=lightweight;browser;web;
This though looks wrong to me. If I remember correctly, the
description of "Keywords" says that you should not repeat general
terms as those which are already used in other values.
Rereading
https://lintian.debian.org/tags/desktop-entry-lacks-keywords-entry.html
and
https://anonscm.debian.org/cgit/collab-maint/links2.git/tree/debian/links2.desktop
I'd rather add "Lightweight Webbrowser" as GenericName and drop the
Keywords key again completely -- or use "Links 2 Webbrowser" as Name.
Anyhow, I don't think "web" and "browser" belong into the Keywords
list.
Regards, Axel
--
,''`. | Axel Beckert <a...@debian.org>, http://people.debian.org/~abe/
: :' : | Debian Developer, ftp.ch.debian.org Admin
`. `' | 4096R: 2517 B724 C5F6 CA99 5329 6E61 2FF9 CD59 6126 16B5
`- | 1024D: F067 EA27 26B9 C3FC 1486 202E C09E 1D89 9593 0EDE
