On Sun, 2016-01-31 at 19:16 +0100, Christian Seiler wrote: > On 12/30/2015 12:13 PM, Christian Seiler wrote: > > Well, that would not be ideal, obviously. But if we propagate the > > error and just ignore 15 (already logged in) then we'll have the > > case that some portals will be in the logged-in state and others > > might not; and if systemd thinks the service didn't successfully > > start, it will not logout of sessions on shutdown. This is > obviously > > not optimal, but because of the follow-up errors there still will > be > > some user feedback, so I think that is the simplest solution. > > So I've added SuccessExitStatus=15 to git (we already had 21 in > there if no sessions are configured, so it's not without > precedent) for now. >
I just tested it with your change. Yes. Now systemd is ignoring errocde 15. root@debian-sanboot:~# systemctl -l status open-iscsi ● open-iscsi.service - Login to default iSCSI targets Loaded: loaded (/lib/systemd/system/open-iscsi.service; enabled; vendor preset: enabled) Active: active (exited) since Sun 2016-02-07 14:39:55 IST; 2min 6s ago Docs: man:iscsiadm(8) man:iscsid(8) Process: 601 ExecStart=/lib/open-iscsi/activate-storage.sh (code=exited, status=0/SUCCESS) Process: 567 ExecStart=/sbin/iscsiadm -m node --loginall=automatic (code=exited, status=15) Process: 559 ExecStartPre=/bin/systemctl --quiet is-active iscsid.service (code=exited, status=0/SUCCESS) Main PID: 601 (code=exited, status=0/SUCCESS) CGroup: /system.slice/open-iscsi.service Feb 07 14:39:51 debian-sanboot systemd[1]: Starting Login to default iSCSI targets... Feb 07 14:39:54 debian-sanboot iscsiadm[567]: iscsiadm: default: 1 session requested, but 1 already present. Feb 07 14:39:55 debian-sanboot iscsiadm[567]: iscsiadm: Could not log into all portals Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Logging in to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.41,3260] (multiple) Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Logging in to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.42,3260] (multiple) Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Logging in to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.43,3260] (multiple) Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Login to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.41,3260] successful. Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Login to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.42,3260] successful. Feb 07 14:39:55 debian-sanboot iscsiadm[567]: Login to [iface: default, target: iqn.2003-01.org.linux-iscsi.debian.sanboot, portal: 172.16.20.43,3260] successful. Feb 07 14:39:55 debian-sanboot systemd[1]: Started Login to default iSCSI targets. > I'm leaving this bug open, because you experienced some other > problems, irrespective of that. If you need help figuring out > what's wrong (perhaps because my earlier changes broke something) > please get in touch. Yes. We have other issues still. I'll follow-up in the other thread. -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System
signature.asc
Description: This is a digitally signed message part
