On 2016-02-20 Daniel Kahn Gillmor <d...@fifthhorseman.net> wrote: [...] > Ugh, it looks like it builds when building from git, but not from a > tarball. This is because we're using autoreconf and upstream's > configure.ac relies on being in a git repo (it selects the revision > number from the number of git commits in the active history).
> The attached patch works to build it from a tarball. It is modelled off > the one we're using for libgpg-error, which derives the revision number > From the length of debian/changelog instead of from the count of git > commits. [...] > - m4_esyscmd([git rev-parse --short HEAD | tr -d '\n\r'])) > + m4_esyscmd([printf %x $(wc -l < debian/changelog)])) [...] Why don't we simply hardcode this as 1, 2 or 42 instead? Having changing builds without source changes (just becuse the lenght of debian/changelog increased) seems wrong to me. cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure'