On Sun, Feb 28, 2016 at 06:00:58PM +0200, Ilias Tsitsimpis wrote: > Control: tags -1 + patch > > Hi François, Nicolas,
Hi, > I have created a patch that hopefully will help here[1]. My plan is to > include this to the next OfflineIMAP version in Debian, and state at the > NEWS file that everyone who is upgrading from v6.3.4 should run > > $ offlineimap --verify-fmd5 || offlineimap --fix-fmd5 > > before the first use of the newer version. > > Could you review this, and/or verify that this is working correctly? > > [1] https://github.com/iliastsi/offlineimap/commit/8d07ec308e83665 >From a quick review, this looks fine for a merge. I didn't check the validity of the algo, though. > @nicolas: Do you believe this should be included in the mainline > OfflineIMAP repository (i.e., do you believe this has any other use > other than upgrading from v6.3.4)? I'm in favor to get this merged ASAP, yes. I think distribution maintainers should backport it to versions from v6.3.4 to v6.7.0-rc2 (the upcoming v6.7.0-rc3 should include the patches). I guess this might be confusing or make bad things (including data loss) if applied on mails that has moved from a folder to another one without a full filename change because this might lead to UID conflicts. -- Nicolas Sebrecht