On Fri, Mar 04, 2016 at 01:49:29PM +0200, Ilias Tsitsimpis wrote: > IIRC the old algo was using the local folder name in order to compute > the FMD5. So, it is relatively easy to check if the current FMD5 matches > that of the local folder name and only then change it to the new one. > This will indeed provide extra insurance against potential UID > conflicts, but at the same time limit the patch to only those cases > where one needs to upgrade from a version older than v6.3.5. I still > cannot find another usage for the above patch (i.e., other cases where > FMD5 has been modified and needs fixing), so, if you like, we may go > that way (and change the name of the flag to something like > --migrate-fmd5-using-nametrans).
That's fine for me. If any new use case is discovered, updating your feature or introduce yet another one should be easy, BTW. > Indeed, the edge-case will occur if the user happens to move a message > since the previous sync. But as rare as this may seems, the results are > very bad (UID conflicts) and users are very sensitive with their emails. > I understand that there is no algorithm that will work for everyone, > hence, we will make sure that they have read the blog-post and made a > backup. Good! > I will update the patch and send a pull request (hopefully by the weekend). Thank you for working on this Ilias! -- Nicolas Sebrecht