Hi Lennart,

On Tue, Mar 08, 2016 at 04:25:06PM +0000, Lennart Weller wrote:
> March 8 2016 1:52 PM, "Sergey Vojtovich" <s...@mariadb.org> wrote:
> > I adjusted your patch a bit, it seem to work well for me. Could you please
> > verify if you're fine with the attached version and it works for you too?
> 
> Well you basically dropped all the safe guards. But in the end its a 
> logrotate script.
> Most people will never have the problem in the first place or know whatwent 
> wrong on
> their end when they see your version of the script. So yeah fine with me.
Nice. So I'll apply this patch to upstream 10.0.

> 
> > You mean "$($MYADMIN flush-logs)" doesn't return 1? I just tested it on my 
> > side
> > and got exit status 1.
> 
> I'll try to find a reproducible bug some other time. But it can happen. 
> EXIT_SUCCESS
> but error on stderr.
I went through relevant code and couldn't immediately find anything like that 
for
"flush-logs". But there's obvious exception for "ping": it may indeed return
success with "error on stderr".

Regards,
Sergey

Reply via email to