Hi, 

On Sat, Feb 20, 2016 at 01:35:37PM +0100, Jérémy Bobbio wrote:
> Package: liblcms2
> Version: 2.6-3
> Severity: normal
> Tags: patch
> User: reproducible-bui...@lists.alioth.debian.org
> Usertags: toolchain randomness
> 
> Hi!
> 
> When writing named colors, liblcms2 currently writes uninitialized memory
> when the prefix, suffix, or root color name strings are not
> 32-characters long (including the NULL terminator). This prevents colord
> from building reproducibly.
> 
> The attached patch will zero the memory before copying the profile
> strings to ensure a consistent output.

I am a bit unsure about the fact that you reduced the size of root[33]
to root[32]. Even if this works out okay in the current code base, such
a change should be made globally (i.e., _cms_NAMEDCOLORLIST_struct
should be changed).

What is your opinion on that?

        Thomas

Reply via email to