On Sat, Mar 19, 2016 at 02:23:31PM +0100, Christian Seiler wrote: > On 03/19/2016 12:34 PM, Mattia Rizzolo wrote: > > On Tue, Jan 19, 2016 at 02:01:19AM +0100, Christian Seiler wrote: > > * d/control: > > + there are commented out Vcs-Git and Vcs-Browser, either set up a > > repository or remove the lines altogether > > I've now set up a repository on collab-maint for that and added the > headers.
oh, nice! though: * please configure the remote git repository to have HEAD pointing to the packaging branch, which is != master * given that this is != master please specify the branch name in Vcs-Git (this is optional if you fix the above, but imho it's better to do both) * please use https and cgit in Vcs-Browser, the very same url that you are using in Vcs-Git is valid in Vcs-Browser too nowadays, so just copy the line over > > + why did you chose a different license for debian/* than the one of > > the rest of the package? This can actually pose a problem, since > > GPL-2+ is more restrictive than LGPL-2.1+. > > I used the default license of dh-make for the Debian packaging part. dh-make considered harmful :( IMHO it just creates a lot of uneeded stuff and most of the time you need to spend more time to clean up the templates than just create all the files by your own... > Since this is a LD_PRELOAD-able library, I seriously doubt anybody > will try to create a derivative work of the resulting binary (which > could arguably be under GPL-2+). OTOH, I don't particularly care, so > I've changed it to LGPL-2.1+ also for debian/*. it's not just about possible derivatives work, but also about patches, if you write a patch in debian/patches with such debian/copyright it should be considered under GPL-2+, and upstream wouldn't be able to import it. That's the theory, at least. > http://mentors.debian.net/debian/pool/main/g/gtk3-nocsd/gtk3-nocsd_2-1.dsc cool! Now, given that you have set up a git repository, feel free to just forget mentors, and just push to git, I'll then just pull ^^ -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature