On Sat, Apr 2, 2016 at 3:06 AM, Sven Joachim <svenj...@gmx.de> wrote:
> On 2016-03-31 19:57 +0900, Roger Shimizu wrote:
>
>> Control: retitle -1 Add udeb support to libtinfo5 and libncurses5
>>
>>
>> Dear Sven,
>>
>> Really appreciate your review and comments!
>> I addressed your concern, and here's patch v2.
>>
>> Changes v2:
>> - add udeb supoort to libncurses5
>
> Care to elaborate why that is needed? The screen package does not
> depend on libncurses5.
Yes, screen in ftp archive doesn't depend on libncurses5.
But if you build now, it depends more libraries than before.
Here's my result:
Depends: libc6 (>= 2.15), libncurses5 (>= 6), libpam0g (>= 0.99.7.1),
libtinfo5 (>= 6), libutempter0 (>= 1.1.5)
>> +Package: libtinfo5-udeb
>> +Package-Type: udeb
>> +Section: debian-installer
>> +Architecture: any
>> +Depends: ${shlibs:Depends}, ${misc:Depends}
>> +Description: shared low-level terminfo library for terminal handling - udeb
>> + The ncurses library routines are a terminal-independent method of
>> + updating character screens with reasonable optimization.
>> + .
>> + This package contains the stripped-down udeb version of shared low-level
>> + terminfo library.
>
> Minor nitpick: you may want to add a "Priority: extra" line, otherwise
> the udebs inherit the priority from the source package (i.e. required).
Fixed in v3.
>> index e1f67dc..063495c 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -471,8 +471,8 @@ endif
>> dh_compress -s -N$(package-examples)
>> dh_fixperms -s
>> dh_link -s
>> - dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)" -- -c4
>> - dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)" -- -c4
>> + dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)"
>> --add-udeb=$(package-ti)-udeb -- -c4
>> + dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)"
>> --add-udeb=$(package-ti)-udeb -- -c4
>
> Surely the last line should read "…--add-udeb=$(package-lib)-udeb…"
> instead?
Thanks for pointing out!
And here goes the patch v3.
Changes v2:
- add udeb supoort to libncurses5
Changes v3:
- add "Priority: extra" to udeb in debian/control
- fix typo when calling dh_makeshlibs
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 17B3ACB1
From c3a9246635351ebf2aead211ce35a0c9b841c372 Mon Sep 17 00:00:00 2001
From: Roger Shimizu <rogershim...@gmail.com>
Date: Sun, 27 Mar 2016 23:15:51 +0900
Subject: [PATCH] Add udeb support to libtinfo5 and libncurses5
---
debian/changelog | 7 +++++++
debian/control | 26 ++++++++++++++++++++++++++
debian/libncurses5-udeb.install | 4 ++++
debian/libtinfo5-udeb.install | 2 ++
debian/rules | 4 ++--
5 files changed, 41 insertions(+), 2 deletions(-)
create mode 100644 debian/libncurses5-udeb.install
create mode 100644 debian/libtinfo5-udeb.install
diff --git a/debian/changelog b/debian/changelog
index a02785a..55ea615 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+ncurses (6.0+20160319-2) UNRELEASED; urgency=medium
+
+ [ Roger Shimizu ]
+ * Add udeb support to libtinfo5 and libncurses5
+
+ -- Roger Shimizu <rogershim...@gmail.com> Sat, 26 Mar 2016 18:22:36 +0900
+
ncurses (6.0+20160319-1) unstable; urgency=medium
* New upstream patchlevel.
diff --git a/debian/control b/debian/control
index a740fa2..8b8509b 100644
--- a/debian/control
+++ b/debian/control
@@ -27,6 +27,19 @@ Description: shared low-level terminfo library for terminal handling
.
This package contains the shared low-level terminfo library.
+Package: libtinfo5-udeb
+Package-Type: udeb
+Section: debian-installer
+Architecture: any
+Priority: extra
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: shared low-level terminfo library for terminal handling - udeb
+ The ncurses library routines are a terminal-independent method of
+ updating character screens with reasonable optimization.
+ .
+ This package contains the stripped-down udeb version of shared low-level
+ terminfo library.
+
Package: libncurses5
Architecture: any
Pre-Depends: ${misc:Pre-Depends}
@@ -40,6 +53,19 @@ Description: shared libraries for terminal handling
This package contains the shared libraries necessary to run programs
compiled with ncurses.
+Package: libncurses5-udeb
+Package-Type: udeb
+Section: debian-installer
+Architecture: any
+Priority: extra
+Depends: libtinfo5-udeb (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
+Description: shared libraries for terminal handling -udeb
+ The ncurses library routines are a terminal-independent method of
+ updating character screens with reasonable optimization.
+ .
+ This package contains the stripped-down udeb version of shared libraries
+ necessary to run programs compiled with ncurses.
+
Package: libtinfo-dev
Architecture: any
Section: libdevel
diff --git a/debian/libncurses5-udeb.install b/debian/libncurses5-udeb.install
new file mode 100644
index 0000000..162fb52
--- /dev/null
+++ b/debian/libncurses5-udeb.install
@@ -0,0 +1,4 @@
+usr/lib/*/libncurses.so.*
+usr/lib/*/libpanel.so.*
+usr/lib/*/libform.so.*
+usr/lib/*/libmenu.so.*
diff --git a/debian/libtinfo5-udeb.install b/debian/libtinfo5-udeb.install
new file mode 100644
index 0000000..c6aa24a
--- /dev/null
+++ b/debian/libtinfo5-udeb.install
@@ -0,0 +1,2 @@
+usr/lib/*/libtinfo.so.*
+usr/lib/*/libtic.so.*
diff --git a/debian/rules b/debian/rules
index e1f67dc..925935f 100755
--- a/debian/rules
+++ b/debian/rules
@@ -471,8 +471,8 @@ endif
dh_compress -s -N$(package-examples)
dh_fixperms -s
dh_link -s
- dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)" -- -c4
- dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)" -- -c4
+ dh_makeshlibs -p$(package-ti) -V "$(package-ti) $(sodepver)" --add-udeb=$(package-ti)-udeb -- -c4
+ dh_makeshlibs -p$(package-lib) -V "$(package-lib) $(sodepver)" --add-udeb=$(package-lib)-udeb -- -c4
dh_makeshlibs -p$(package-libw) -V "$(package-libw) $(sodepver)" -- -c4
ifneq ($(build_32),)
dh_makeshlibs -p$(package-ti-32) -V "$(package-ti-32) $(sodepver)" -- -c4
--
2.8.0.rc3
