tag 812486 - moreinfo + patch
thanks
Hi,
In data domenica 24 gennaio 2016 16:19:54, Axel Beckert ha scritto:
> Pino Toscano wrote:
> > In addition, a couple of helpful keywords are added to that.
> [...]
> > Categories=Network;WebBrowser;
> [...]
> > +Keywords=lightweight;browser;web;
>
> This though looks wrong to me. If I remember correctly, the
> description of "Keywords" says that you should not repeat general
> terms as those which are already used in other values.
Right -- it isn't wrong though, just redundant.
Attached a new git commit with just the validation fix -- of course,
feel free to add more keywords that fit.
Side note: considering a .desktop file is shipped, then the menu file
could be dropped (see #741573).
P.S.: what about forwarding it upstream?
Thanks,
--
Pino Toscano
>From bd039d04234c2c1d5423efbab9ccbd0ea760c7bb Mon Sep 17 00:00:00 2001
From: Pino Toscano <p...@debian.org>
Date: Sat, 16 Apr 2016 14:38:00 +0200
Subject: [PATCH] Update links2.desktop (#812486)
The 'Keywords' key is a list, so it must end with the list separator
(';').
---
debian/changelog | 4 ++++
debian/links2.desktop | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 7e53757..0799787 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,10 @@ links2 (2.12-2) UNRELEASED; urgency=medium
* Add new spelling-error-in-binary lintian override for "NAm" (not found
in source, likely part of a symbol or such).
+ [ Pino Toscano ]
+ * Update links2.desktop: the 'Keywords' key is a list, so it must end
+ with the list separator (';'). (Closes: #812486)
+
-- Axel Beckert <a...@debian.org> Sat, 30 Jan 2016 17:02:40 +0100
links2 (2.12-1) unstable; urgency=medium
diff --git a/debian/links2.desktop b/debian/links2.desktop
index f2541e2..69cd0e9 100644
--- a/debian/links2.desktop
+++ b/debian/links2.desktop
@@ -8,4 +8,4 @@ Terminal=false
Categories=Network;WebBrowser;
Comment=Web browser running in both graphics and text mode
Comment[pt_BR]=Navegador web que funciona tanto no modo texto como no modo gráfico
-Keywords=lightweight
\ No newline at end of file
+Keywords=lightweight;
--
2.8.0.rc3
