Hello Christian, Christian Seiler [2015-03-15 15:23 +0100]: > deb-systemd-helper doesn't handle drop-ins at all (only the main > service file is parsed) and it doesn't treat lists properly: when > creating links for Alias=, it doesn't properly treat multiple entries > in the same line ($1 instead of $_ used), when removing links for > Also=, it assumes that there's only ever one entry per line, and it > doesn't support systemd's syntax to reset a list to empty (which native > systemd supports for the [Install] section entries).
It's been a while, sorry for not getting to this earlier! Do you think you can update the patch to current i-s-h 1.30? I'm afraid it does not apply any more. > Also, while I've tested this to some extent, I haven't done extensive > stress testing of these changes. I'm fairly certain it's correct the > way it is, but I have to admit I'm not a Perl guy, so you should > double-check this. I HAVE diverted deb-systemd-helper on my system > now and replaced it with this, so I'll hopefully notice mistakes. The patch LGTM in general. Did you see any fallout? Thanks, Martin -- Martin Pitt | http://www.piware.de Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
