Hi Gianfranco,

thanks for your review.

On 04/27/2016 01:28 PM, Gianfranco Costamagna wrote:
> can you please explain the changes below (to me or in changelog)
> 
> -usr/lib/*/purple-2/libsipe.so usr/lib/purple-2
> -usr/share/locale/*
> -usr/share/pixmaps/*

After removing pidgin-sipe-dbg, pidgin-sipe remained the sole binary package
that is generated from the source, and debhelper started installing the files
directly under debian/pidgin-sipe instead of debian/tmp, so those lines in
pidgin-sipe.install moving files from one location to the other aren't needed
any longer.

> +export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
> 
> 
> 1) maybe you can try to hardening=+all

I updated this in git and re-uploaded to mentors.

> and --libdir=/usr/lib seems a good way to avoid multiarch...
> why?

Pidgin searches for protocol plugins only in /usr/lib/purple-2. Multiarch
location doesn't work and thus I have to avoid it here. This change reflects
the above mentioned line which used to be in pidgin-sipe.install:

  usr/lib/*/purple-2/libsipe.so usr/lib/purple-2

> 2) I see "libpurple-dev (>= 2.10.11-1.1)"
> 
> and this on changelog:
> +       - add support for Lync File Transfer protocol (Jakub Adam)
> +         * requires libpurple >= 2.12.0
>
> maybe you should bump the version?

We don't have recent enough Pidgin (only 2.10.11) in Debian. I've raised a bug 
against
the package [1] requesting an update. Until its maintainer makes a new upload, 
though,
file transfer won't be available. Also I see I've made a mistake in the 
(upstream)
changelog; it should be 2.10.12, not 2.12.0...

Regards,

Jakub

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822782

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to