Thanks for your work in packaging this!

I'd be happy to sponsor the package.  I noticed you have Pierre
Chifflier <pol...@debian.org> listed in the Uploaders: field ... is
he already sponsoring the package?  If so I'll gladly defer.

I took a quick look and came up with a few minor nits:

  -- The debian/copyright file was missing '2015' in some of the
entries.

  -- The debian/copyright file was using 'GPL-3.0+' instead of
'GPL-3+'  (DEP5 doesn't seem to mandate 3+ vs 3.0+, but it uses it
in the examples, and using GPL-3+ makes license-reconcile happy).

  -- The copyright for scap-workbench-osx-ssh-askpass.sh is
different and needs to be documented in debian/copyright.

  -- Ditto for cmake/GNUInstallDirs.cmake ... this is a bit trickier
since it says "see accompanying file Copyright.txt for details", but
doesn't include Copyright.txt.  Is this something that could be
fixed upstream?  Ideally I'd love to see the build use the installed
GNUInstallDirs.cmake from cmake-data instead of shipping its own ---
but I understand there may be other issues involved that prevent that.

  -- The user_manual.html included with the sources includes the
Asciidoctor stylesheet (MIT license), but that isn't documented.

I wonder if it would make sense to remove user_manual.html and
GNUInstallDirs.cmake from the package using Files-Excluded?  That
would remove the need to mess around with user_manual.html in
debian/rules.  But I know that it's a tradeoff.

I pushed updates to debian/copyright and
debian/license-reconcile.yml to a fork on
https://anonscm.debian.org/git/users/klee/scap-workbench.git, if
they are useful to you.

Let me know how I can best work with you, and I'd be happy to get an
upload going.  Thanks again for your work!  I'm happy to collaborate
on this and other similar projects.

Reply via email to