On 2015-11-05 10:33:46 [+0000], Chris Lamb wrote: > Dear Maintainer, > > percona-xtradb-cluster-galera-2.x fails to build from source in > unstable/amd64:
the patch attached would let it build again. Do we want this? From what I read at the github page [0] is that the current series is the 3.x ones while this seems to be an older 2.x. So do we want this package fixed or rather a removal and 3.x packaged by someone who needs / uses it? [0] https://github.com/codership/galera/tree/3.x Sebastian
diff -Nru percona-xtradb-cluster-galera-2.x-2.11.2675/debian/changelog percona-xtradb-cluster-galera-2.x-2.11.2675/debian/changelog --- percona-xtradb-cluster-galera-2.x-2.11.2675/debian/changelog 2015-08-30 23:49:37.000000000 +0200 +++ percona-xtradb-cluster-galera-2.x-2.11.2675/debian/changelog 2016-05-04 23:09:16.000000000 +0200 @@ -1,3 +1,12 @@ +percona-xtradb-cluster-galera-2.x (1:2.11.2675-1.3) unstable; urgency=medium + + * Non-maintainer upload. + * Depend on libasio-dev to avoid build failure on internal asio copy + (Closes: #804138). + * Replace _BSD_SOURCE with _DEFAULT_SOURCE to avoid a warning with -Werror + + -- Sebastian Andrzej Siewior <sebast...@breakpoint.cc> Wed, 04 May 2016 23:02:27 +0200 + percona-xtradb-cluster-galera-2.x (1:2.11.2675-1.2) unstable; urgency=medium * Non-maintainer upload. diff -Nru percona-xtradb-cluster-galera-2.x-2.11.2675/debian/control percona-xtradb-cluster-galera-2.x-2.11.2675/debian/control --- percona-xtradb-cluster-galera-2.x-2.11.2675/debian/control 2015-08-30 23:37:25.000000000 +0200 +++ percona-xtradb-cluster-galera-2.x-2.11.2675/debian/control 2016-05-04 23:09:16.000000000 +0200 @@ -9,6 +9,7 @@ libboost-dev (>= 1.41), libboost-program-options-dev (>= 1.41), libssl-dev, + libasio-dev, scons Standards-Version: 3.9.6 Homepage: http://www.percona.com/software/percona-xtradb-cluster/ diff -Nru percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/series percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/series --- percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/series 2015-08-30 23:42:40.000000000 +0200 +++ percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/series 2016-05-04 23:09:00.000000000 +0200 @@ -1,3 +1,4 @@ detect-atomic.patch fix-atomic-and-align.patch gcc5.patch +sslv3_fixup.patch diff -Nru percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/sslv3_fixup.patch percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/sslv3_fixup.patch --- percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/sslv3_fixup.patch 1970-01-01 01:00:00.000000000 +0100 +++ percona-xtradb-cluster-galera-2.x-2.11.2675/debian/patches/sslv3_fixup.patch 2016-05-04 23:11:30.000000000 +0200 @@ -0,0 +1,31 @@ +From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc> +Subject: Fix build without SSLv3 + +- use external libasio-dev isntead of the internal copy which seems to work +- avoid using _BSD_SOURCE which triggers a warning (and fails to compile with + -Werror) +Index: percona-xtradb-cluster-galera-2.x-2.11.2675/SConstruct +=================================================================== +--- percona-xtradb-cluster-galera-2.x-2.11.2675.orig/SConstruct ++++ percona-xtradb-cluster-galera-2.x-2.11.2675/SConstruct +@@ -186,7 +186,6 @@ if extra_sysroot != '': + + # Include paths + env.Append(CPPPATH = Split('''#/common +- #/asio + #/galerautils/src + #/gcomm/src + #/gcomm/src/gcomm +Index: percona-xtradb-cluster-galera-2.x-2.11.2675/galerautils/src/gu_fifo.c +=================================================================== +--- percona-xtradb-cluster-galera-2.x-2.11.2675.orig/galerautils/src/gu_fifo.c ++++ percona-xtradb-cluster-galera-2.x-2.11.2675/galerautils/src/gu_fifo.c +@@ -13,7 +13,7 @@ + * minimum space when there are few items in the queue. + */ + +-#define _BSD_SOURCE ++#define _DEFAULT_SOURCE + + #include <stdio.h> + #include <string.h>