Hi,

The temporary IFS overriding is necessary IMHO, otherwise the test on $VAL non-emptiness might failed/raised an error for header with space, for instance with header like: "X-My-Header: string".

To remove IFS overriding completely, we need to quote $VAL i think:

------------------------8<---------------------
while [ ! -z "$VAL" ] ; do
    XHEADERS="$XHEADERS -a \"$VAL\""
    i=$(( $i + 1 ))
    eval "VAL=\${XHEADER$i}"
    echo $XHEADERS
done
------------------------>8---------------------

I tested the cron-apt functions you sent with the above patch, it looks ok.

Le 17/05/2016 12:46, Ola Lundqvist wrote :
Hi again

I have done some more changes. Can you test with this file?

// Ola

On Tue, May 17, 2016 at 10:59 AM, Geoff <mxondeb...@free.fr
<mailto:mxondeb...@free.fr>> wrote:

    Hi,

    Le 03/05/2016 23:51, Ola Lundqvist a écrit :

        Hi again

        No sorry, replace the <TAB> with nothing or space. That should
        do the trick.


    Replacing "<TAB>" with nothing is not enough.
    Each XHEADER has to be quoted as well.
    Mail command with cli options is then eval.

    Here is a quick and not so pretty patch, please review.

    Tested on debian 8.2.

    Cheers,
    Geoff




--
  --- Inguza Technology AB --- MSc in Information Technology ----
/ o...@inguza.com <mailto:o...@inguza.com>                    Folkebogatan
26            \
| o...@debian.org <mailto:o...@debian.org>                   654 68
KARLSTAD            |
| http://inguza.com/                Mobile: +46 (0)70-332 1551 |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9  /
  ---------------------------------------------------------------


Reply via email to