On 2016-06-01 21:49:44 +0200, Guus Sliepen wrote:
> On Wed, Jun 01, 2016 at 09:06:20PM +0200, Vincent Lefevre wrote:
> > This means that various ifup scripts are probably buggy.
> 
> What makes you think that?

Various scripts (like mine) have:

[ "$IFACE" != "lo" ] || exit 0

without testing "$IFACE" != "--all" or testing $ADDRFAM = "meta".

An example is avahi-autoipd, which has:

[ "$IFACE" != "lo" ] || exit 0

then later:

        /bin/ip route add 169.254.0.0/16 dev $IFACE metric 1000 scope link

Note that $IFACE is expected here to be an interface, not --all!

> According to what you said earlier, it was hanging in z_home_net,
> which is not in any official Debian package, so I assume this script
> was written by you?

Yes.

> I haven't heard any reports of other scripts breaking, and ifupdown
> has been calling the scripts with IFACE="--all" since early 2012.

The breakage may be silent.

> > Also, why doesn't ifup write a log message about --all?
> 
> So far there was no reason for it.

It would be better to know what's going on. There's a log message
for real interfaces. For the same reason, one could expect one for
--all.

Moreover, the interfaces(5) man page says:

       IFACE  physical name of the interface being processed

This is obviously wrong when IFACE is set to "--all".

-- 
Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Reply via email to