control: owner -1 !
control: tag -1 +moreinfo
Dear Jacob,
This looks like a nice alternative to redshift-gtk. Thanks for
packaging it. I can't sponsor the upload, but I hope this review is
useful to you.
1. Could you explain why you are packaging your fork rather then the
original? (This kind of thing should go in the ITP.)
2. Could you put your Debian packaging in git, please? It makes
reviewing easier. Perhaps as a 'debian' branch of your repo.
3. The formatting of the long description in debian/control is a bit
strange. Please separate paragraphs using a line with the string
" .". Probably best to wrap at 70 chars, too.
4. The wording of the long description could be improved. The first
sentence isn't really a sentence -- it would be better to write "sct
is a small C program to change the screen color temperature. It can
be used to reduce or increase the amount of blue light produced by
the screen." Please take another look at your wording :)
5. Have you considered calling the binary package 'sct'? That is what
someone might guess when they want to install this with apt-get.
6. 'sct' is a very short command name for /usr/bin ... have you
confirmed that it doesn't clash with any other packages in Debian?
You might have to set the priority to 'extra'.
7. The language in d/copyright ("I doubt if it's copyrightable" etc.)
isn't appropriate. You need to determine whether or not it is
copyrightable and make a clear statement of that.
8. This doesn't make sense (doesn't follow DEP-5 machine-readable
copyright file format) -- please check:
Files: sct.c
Copyright: 2016 Ted Unangst <t...@openbsd.org>
whitepoints data copyright 2013 Ingo Thies <ith...@astro.uni-bonn.de>
License: public-domain-sct and public-domain-colorramp
9. Please install the README into /usr/share/doc.
10. You're missing at least one build dependency. Please try building
in a clean sid chroot (see the pbuilder or sbuild tools).
--
Sean Whitton
