On 2016-07-25 18:14 +0100, Wookey wrote:
> On 2016-07-25 18:05 +0200, Sven Joachim wrote:
>> Source: jed
>> Version: 1:0.99.19-5
>> Severity: normal
>>
>> I have noticed the following typo in debian/rules:
>>
>> DEB_HOST_MULTIARCH ?=$(shell dpgk-architecture -qDEB_HOST_MULTIARCH)
>>
>> This is not a problem when using dpkg-buildpackage since it sets
>> DEB_HOST_MULTIARCH for us, but when invoking debian/rules directly,
>> DEB_HOST_MULTIARCH will be set to the empty string.
>
> Sorry I'm being dim here. I think that should set DEB_HOST_MULTIARCH
> (to the result of 'dpgk-architecture -qDEB_HOST_MULTIARCH'), unless
> DEB_HOST_MULTIARCH is already set to something in which case it should
> keep that value. Am I wrong? I don't see why it should end up null if
> invoked directly as a make rule.
Because there is no dpgk-architecture, only dpkg-architecture. Running
dpgk-architecture does not print anything on stdout, but only gives an
error message from the shell on stderr.
>> Nevertheless, jed
>> builds fine even then which suggests that passing --with-slanglib and
>> --with-slanginc is not really necessary although the comments say
>> otherwise.
>
> This may be because I changed to debhelper 9 mode, which IIRC sets this
> variable automatically anyway, so this bit in the rules file is
> probably pointless.
No, debhelper 9 mode only matters if you use dh(1) in the rules file.
Cheers,
Sven
