That is definitely an improvement. :-) Inasmuch as websec automatically creates the .websec directory, it would also be reasonable to create an empty (or template) url.list.
cheers,
Charles
-----Original Message-----
> From: Baruch Even <[EMAIL PROTECTED]>
> Subject: Re: Bug#349024: websec: hangs w/out url.list
> Date: Fri, 20 Jan 2006 16:52:18 +0000
> To: Charles Fry <[EMAIL PROTECTED]>, [EMAIL PROTECTED]
> Cc: [EMAIL PROTECTED]
>
> package websec
> tag 349024 + patch
> thanks
>
> Charles Fry wrote:
> > After first installing websec, I tried running it prior to creating a
> > url.list and it simply hung. It should at least be able to fail cleanly
> > and tell me that it needs a url.list. :-)
>
> Yes, that's pretty dumb. I've committed a fix in the upstream repository
> and it will be in the next version.
>
> The patch is between revisions 182 and 184:
> Index: websec
> ===================================================================
> --- websec (revision 182)
> +++ websec (revision 184)
> @@ -143,8 +143,14 @@
> # Default return code
> $rc = 0;
>
> -open ARGV, $base . "/" . "$urllist" unless exists $ARGV[0];
> +my $urllistfile = $base . "/" . "$urllist";
> +if (! -e $urllistfile) {
> + print STDERR "Missing config file $urllistfile, Exiting.\n";
> + exit 1;
> +}
>
> +open ARGV, "$urllistfile" unless exists $ARGV[0];
> +
> # Loop through input file and process all sites listed
> while (<>) {
> chop $_;
--
Henry the Eighth
Prince of friskers
Lost five wives
But kept
His whiskers
Burma-Shave
http://burma-shave.org/jingles/1938/henry_the_eighth
signature.asc
Description: Digital signature
