Package: krb5
Version: 1.14.3+dfsg-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu yakkety ubuntu-patch
Hi Sam,
As you saw in https://bugs.launchpad.net/bugs/1592841, krb5 was failing to
build in Ubuntu on ppc64el because we build that architecture with -O3
optimization, which detected some additional uninitialized variables at
compile time compared to the Debian toolchain.
The attached patch was uploaded to fix the build failure in Ubuntu, but does
not appear to have been included in either Debian or upstream. Could you
consider applying it in Debian, so that the krb5 package can be in sync
again?
Thanks,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru krb5-1.14.3+dfsg/debian/patches/0011-sendto_kdc-uninitialized-variable.patch krb5-1.14.3+dfsg/debian/patches/0011-sendto_kdc-uninitialized-variable.patch
--- krb5-1.14.3+dfsg/debian/patches/0011-sendto_kdc-uninitialized-variable.patch 1969-12-31 16:00:00.000000000 -0800
+++ krb5-1.14.3+dfsg/debian/patches/0011-sendto_kdc-uninitialized-variable.patch 2016-06-15 22:57:49.000000000 -0700
@@ -0,0 +1,45 @@
+From 0696cc5a5dfb59f15dc0212d58aa509066212b65 Mon Sep 17 00:00:00 2001
+From: Steve Langasek <steve.langa...@ubuntu.com>
+Date: Thu, 16 Jun 2016 08:57:00 +0300
+Subject: sendto_kdc uninitialized variable
+
+---
+ src/lib/krb5/os/sendto_kdc.c | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+Index: krb5-1.14.2+dfsg/src/lib/krb5/os/sendto_kdc.c
+===================================================================
+--- krb5-1.14.2+dfsg.orig/src/lib/krb5/os/sendto_kdc.c
++++ krb5-1.14.2+dfsg/src/lib/krb5/os/sendto_kdc.c
+@@ -339,7 +339,8 @@ cm_select_or_poll(const struct select_st
+ struct timeval tv;
+ #endif
+ krb5_error_code retval;
+- time_ms curtime, interval;
++ time_ms curtime = 0;
++ time_ms interval;
+
+ retval = get_curtime_ms(&curtime);
+ if (retval != 0)
+@@ -1315,7 +1316,7 @@ service_fds(krb5_context context, struct
+ void *msg_handler_data, struct conn_state **winner_out)
+ {
+ int e, selret = 0;
+- time_ms endtime;
++ time_ms endtime = 0;
+ struct conn_state *state;
+
+ *winner_out = NULL;
+Index: krb5-1.14.2+dfsg/src/tests/asn.1/trval.c
+===================================================================
+--- krb5-1.14.2+dfsg.orig/src/tests/asn.1/trval.c
++++ krb5-1.14.2+dfsg/src/tests/asn.1/trval.c
+@@ -404,7 +404,7 @@ int do_cons(fp, enc, len, lev, rlen)
+ {
+ int n;
+ int r = 0;
+- int rlen2;
++ int rlen2 = 0;
+ int rlent;
+ int save_appl;
+
diff -Nru krb5-1.14.3+dfsg/debian/patches/series krb5-1.14.3+dfsg/debian/patches/series
--- krb5-1.14.3+dfsg/debian/patches/series 2016-07-30 18:56:43.000000000 -0700
+++ krb5-1.14.3+dfsg/debian/patches/series 2016-07-31 16:01:55.000000000 -0700
@@ -8,3 +8,4 @@
debian-local/0008-Use-isystem-for-include-paths.patch
debian-local/0009-Fix-krb5-config-paths.patch
0010-Initial-German-translations.patch
+0011-sendto_kdc-uninitialized-variable.patch
