On Mon, Aug 15, 2016 at 11:24:05AM +0100, Chris Lamb wrote:
> Hi Zbigniew,
>
> > > https://kojipkgs.fedoraproject.org//work/tasks/890/13300890/build.log
> [..]
> > https://kojipkgs.fedoraproject.org//work/tasks/2994/13312994/build.log
> [..]
> > https://kojipkgs.fedoraproject.org//work/tasks/834/13300834/build.log)
>
> Alas these links now 404. Could you let me know:
Hi,
unfortunately failed builds are purged from koji after some time. I periodically
forget about that.
> a) Whether you still see these errors (and link to fresher URLs?)
I see only a single error. It was also on that list. Others have been fixed:
======================================================= FAILURES
========================================================
___________________________________________________ test_differences
____________________________________________________
differences = [<Difference test1.ext4.tar -- test2.ext4.tar [<Difference file
list -- file list []>, <Difference ./date.txt -- ./date.txt [<Difference
encoding -- encoding []>]>]>]
@pytest.mark.skipif(not guestfs_working(), reason='guestfs not working on
the system')
@pytest.mark.skipif(tool_missing('qemu-img'), reason='missing qemu-img')
@pytest.mark.skipif(miss_guestfs, reason='guestfs is missing')
def test_differences(differences):
assert differences[0].source1 == 'test1.ext4.tar'
tarinfo = differences[0].details[0]
tardiff = differences[0].details[1]
encodingdiff = tardiff.details[0]
assert tarinfo.source1 == 'file list'
assert tarinfo.source2 == 'file list'
assert tardiff.source1 == './date.txt'
assert tardiff.source2 == './date.txt'
assert encodingdiff.source1 == 'encoding'
assert encodingdiff.source2 == 'encoding'
expected_diff = open(os.path.join(os.path.dirname(__file__),
'../data/ext4_expected_diffs'), encoding='utf-8').read()
found_diff = tarinfo.unified_diff + tardiff.unified_diff +
encodingdiff.unified_diff
> assert expected_diff == found_diff
E assert '@@ -1,3 +1,3...cii\n+utf-8\n' == '@@ -1,3 +1,3 ...cii\n+utf-8\n'
E @@ -1,3 +1,3 @@
E - -drwxr-xr-x 0 0 0 0 2015-12-02
16:01:40.000000 ./
E - +drwxr-xr-x 0 0 0 0 2015-12-02
16:03:11.000000 ./
E - drwx------ 0 0 0 0 2015-12-02
16:00:55.000000 ./lost+found/
E + -drwxr-xr-x 0 root (0) root (0) 0
2015-12-02 16:01:40.000000 ./
E + +drwxr-xr-x 0 root (0) root (0) 0
2015-12-02 16:03:11.000000 ./
E + drwx------ 0 root (0) root (0) 0
2015-12-02 16:00:55.000000 ./lost+found/
E --rw-rw-rw- 0 1234 1234 28 2015-12-02
16:01:40.000000 ./date.txt
E +-r--r--r-- 0 4321 4321 44 2015-12-02
16:03:11.000000 ./date.txt
E @@ -1 +1 @@
E -Wed Dec 2 17:01:40 CET 2015
E +jeudi 3 décembre 2015, 06:03:11 (UTC+1400)
E @@ -1 +1 @@
E -us-ascii
E +utf-8
tests/comparators/test_fsimage.py:85: AssertionError
=================================== 1 failed, 197 passed, 35 skipped in 61.54
seconds ===================================
> b) How, exactly, you are invoking the tests. This matters because
> diffoscope does some "environment reset" (see ``set_locale``) but
> its not always called and probably isn't during tests. This might
> be deliberate, I haven't looked into it.
I invoke the tests as "PYTHONPATH=. py.test-3 . -vv" locally. Above output
is from that.
Let me know if I should provide additional information.
Zbyszek
