Hello Gregor,
> > The package has been accepted on the mentor queue and is available here: > > https://mentors.debian.net/package/fwknop > > Thanks, and sorry for the delay in reviewing. > Do not worry :) > > Note: Right now I do not have access to the git repository but I will > > investigate if I can do something for that. > > Ok. > I cannot use my previous Debian account anymore - the SSH key has been disabled. > Some notes: > > - d/copyright: > This needs an update, according to the diff the new copyright > statement (for "Files: *") is now: > > - Copyright 2009-2013, Damien Stuart and Michael Rash > +Copyright (C) 2009-2015 fwknop developers and contributors. For a full > +list of contributors, see the file 'CREDITS'. > Updated > - d/rules: > Another way to set bindnow is: > export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow > Cf. man 1 dpkg-buildflags > I did see this method, but I did not use it a few weeks ago, since I wanted to give a try manually first. I forgot to update the debian/rules with DEB_BUILD_MAINT_OPTIONS afterwards. It is done in the new package I have uploaded to mentors.debian.net > - debug packages: > You can drop the -dbg packages, we have automatic -dbgsym packages > now. Cf. e.g. man 1 dh_strip. > (And since the packages are renamed, I think we don't need the > migration handling here.) > That is good to know. > - there's a warning about sysmbols during build: > dpkg-gensymbols: warning: some libraries disappeared in the symbols file: > libfko.so.2 > dpkg-gensymbols: warning: debian/libfko3/DEBIAN/symbols doesn't match > completely debian/libfko3.symbols > [..] > not sure if this is a problem or not ... > hm, why "libfko.so.2" > I forgot to remove the libfko2 symbols from the debian/libfko3.symbols. It is fixed. > - As for the renaming of the libraries, I'm not sure if we need to do > a bit more. I guess there are no reverse dependencies outside this > source package? But even then, we should help users to get rid of > the libfko2* packages, probably with Breaks: libfko2* > (I see that libfko3-dev has a "Conflicts: libfko-dev".) > Cf. https://wiki.debian.org/RenamingPackages (although I guess we > need only the Breaks. -- Oh, no, we also need Replaces, as e.g. > libfko3-dev installs ./usr/include/fko.h and > ./usr/lib/x86_64-linux-gnu/libfko.a > And for the dbg/dbgsym-package we probably do also need > dh_strip --dbgsym-migration ... > > And lots of time later I have something which seems to work; cf. > attached diff. > Good catch for the replace/break/conflicts. Everything should be up-to-date on mentors.debian.net. I hope everything is fine now. The package is lintian clean (except from one experimental tag) and it builds fine in a sid/amd64 cowbuilder chroot. PS: I am glad, I have reinstalled my cowbuilder chroots along with my old utilities to check the Debian packages. Best regards and thanks again for your time Gregor. -- Franck
