Control: tag -1 pending

Applied, but:

> 
> --- a/drivers/firmware/efi/libstub/fdt.c
> +++ b/drivers/firmware/efi/libstub/fdt.c
> @@ -139,6 +139,13 @@ efi_status_t update_fdt(efi_system_table_t
> *sys_table, void *orig_fdt,
>                       return efi_status;
>               }
>       }
> +
> +     fdt_val32 = efi_get_secureboot(sys_table);

Shouldn't there be a cpu_to_fdt32() conversion here?

> 
> +     status = fdt_setprop(fdt, node, "linux,uefi-secure-boot",
> +                          &fdt_val32, sizeof(fdt_val32));
> +     if (status)
> +             goto fdt_set_fail;
> +
>       return EFI_SUCCESS;
>  
>  fdt_set_fail:

Ben.

-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had
thought.
... I realized that a large part of my life from then on was going to
be spent
in finding mistakes in my own programs. - Maurice Wilkes, 1949
-- 
Ben Hutchings
[W]e found...that it wasn't as easy to get programs right as we had
thought.
... I realized that a large part of my life from then on was going to
be spent
in finding mistakes in my own programs. - Maurice Wilkes, 1949

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to