Hello Ian,

On Thu, Oct 20, 2016 at 01:37:46AM +0100, Ian Jackson wrote:
> Sean Whitton writes ("Re: Bug#840153: Should have various tutorial manpages"):
> > On Wed, Oct 19, 2016 at 09:31:28PM +0100, Ian Jackson wrote:
> > I'll ensure that I don't commit stuff that doesn't build, now that I
> > know I can submit patches by publishing a branch somewhere.  The patches
> > were ordered the way they were so that I could easily --amend the patch
> > that adds the manpage.
> 
> Aha.  Are you aware of
>   git rebase -i --autosquash
> ?

Ah, cool.  So that's what those Magit[1] options are for.

> > I don't understand the two non-trivial changes you've made to the
> > text of the manpage.  I hope you can explain further.
> 
> I think you may mean you don't agree :-).

At least (2) was a lack of understanding!

> Sure.  Would you care to add that as a commit on top of my branch ?  I
> don't really mind flail in the git history if the intervening commits
> pass the tests and don't contain garbage.
> 
> You might want to mention that if you do this check, you might as well
> use the upstream tarball rather than `git-archive'.

Done: https://git.spwhitton.name/dgit -b wip.manpages

> > (2) the removal of the advice to use --squash:
> > 
> > Could you explain why you think this was bad advice?  It ensures that
> > the bad refs are *not* pushed to dgit-repos.  I agree with your addition
> > of contact details for the relevant archive administrators.
> 
> I don't think this is a sufficiently robust way of responding to the
> discovery of harmful and/or legally dangerous objects in a public git
> history.

Yes, you're right.  Even if someone wanted to use --squash, the
blacklisting would need to be in place to prevent accidents later, so
they might as well just contact the relevant administrators.

[1] http://magit.vc/

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature

Reply via email to