On 2016-11-04 15:50, Ghislain Vaillant wrote:
Hi Gilles,
On 01/11/16 17:50, Gilles Filippini wrote:
Could you give me more insight of the compatibility problem with HDF5
1.10?
The most important change in the HDF5 1.10 release is that the hid_t
type was changed from 'int' to 'long long' [1]. Assuming that hid_t is
int isn't true anymore. Thus the change to the ISMRMRD_Dataset
structure, because the fileid field is actually used as an hid_t. See
for example the ismrmrd_open_dataset() function in libsrc/dataset.c:
int ismrmrd_open_dataset(ISMRMRD_Dataset *dset, const bool
create_if_needed) {
/* TODO add a mode for clobbering the dataset if it exists. */
hid_t fileid;
...
fileid = H5Fopen(dset->filename, H5F_ACC_RDWR, H5P_DEFAULT);
if (fileid > 0) {
dset->fileid = fileid;
}
...
I submitted your patch to a PR upstream for review:
https://github.com/ismrmrd/ismrmrd/pull/74
Since there were no DEP3 header attached to the patch, I used your
Debian name and email for the commit authorship. I hope this is ok.
No problem. Thank you for the follow up.
_g.
