Hi, On Sat, Oct 29, 2016 at 04:34:24PM +0200, Corentin Noël wrote: > Here is a patch adding the pkg-config files for the apt-pkg and apt-inst > packages.
Thanks! Unfortunately, I am not experienced with pkg-config stuff, so ideally I will leave that up for someone else to handle, but a few superficial comments none the less: > +Name: @PACKAGE@ "Name: apt" feels strange. Especially if we ship two with the same name… I think I would expect (lib)apt-pkg or (lib)apt-inst here. Not sure. > +Description: Read deb packages informations > +Description: Manage deb packages That is… very generic to a point that it is nearly wrong. Maybe: query and extract information from deb packages & query and manage packages and the metadata about them (which is roughly what the Description fields in debian/control say) The URL could be our tracker page [0], it is the closest we have to a Homepage and contains all the usual pointers like Git, News, Bugs, … [0] https://tracker.debian.org/pkg/apt > +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/apt-pkg.pc DESTINATION > ${CMAKE_INSTALL_LIBDIR}/pkgconfig) That doesn't seem to be enough to install the files. At least I don't see them shipped in libapt-pkg-dev with this alone. You will likely need to adapt debian/libapt-pkg-dev.install. Slightly related: It seems relatively conventional that library packages have an autopkgtest compiling the equivalent of a hello world program against them. Adding such a test shouldn't be hard (at least I hope so) & could provide some confidence that the pkg-config files actually work (and will continue to work in the future) – and that the libraries aren't completely broken either of course. :) Best regards David Kalnischkies
signature.asc
Description: PGP signature